Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default settings compatibility issue: eslint-plugin-n #2861

Open
JosephBarkate opened this issue Dec 7, 2024 · 3 comments
Open

Default settings compatibility issue: eslint-plugin-n #2861

JosephBarkate opened this issue Dec 7, 2024 · 3 comments
Labels

Comments

@JosephBarkate
Copy link

Describe the bug

Installing the boilerplate with: npx ignite-cli@latest new PizzaApp, and accepting all the default settings leads to a compatibility issue while doing my first npm install.

The error:
git:(main) ✗ npm install npm ERR! code ERESOLVE npm ERR! ERESOLVE could not resolve npm ERR! npm ERR! While resolving: eslint-config-standard@17.1.0 npm ERR! Found: eslint-plugin-n@17.14.0 npm ERR! node_modules/eslint-plugin-n npm ERR! dev eslint-plugin-n@"^17.10.2" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer eslint-plugin-n@"^15.0.0 || ^16.0.0 " from eslint-config-standard@17.1.0 npm ERR! node_modules/eslint-config-standard npm ERR! dev eslint-config-standard@"^17.1.0" from the root project

The Solution:
Not ideal but to get around this I downgraded two package versions and my boilerplate seems to be installing correctly now. These are the two packages I had to downgrade 1 major version:

"eslint-plugin-n": "^16.0.0", "eslint-plugin-promise": "^6.0.0",

Not sure if this will eventually be fixed upstream or if its requires a PR, but would appreciate a second opinion. Thanks again for providing this product!

Ignite version

release

Additional info

System
  platform           darwin                                              
  arch               arm64                                               
  cpu                12 cores      Apple M3 Pro                          
  directory          neighborrow   /Users/jbarkate/workspace/neighborrow 

JavaScript (and globally-installed packages)
  node               21.6.1       /Users/jbarkate/.nvm/versions/node/v21.6.1/bin/node 
  npm                10.2.4       /Users/jbarkate/.nvm/versions/node/v21.6.1/bin/npm  
    corepack         0.24.0                                                           
    eas-cli          14.0.2                                                           
    npm              10.2.4                                                           
  yarn               -            not installed                                       
  pnpm               -            not installed                                       
  bun                -            not installed                                       
  expo               51.0.39      managed                                             

Ignite
  ignite-cli         10.0.5       /Users/jbarkate/.npm/_npx/e31027f3785124a8/node_modules/.bin/ignite      
  ignite src         build        /Users/jbarkate/.npm/_npx/e31027f3785124a8/node_modules/ignite-cli/build 

Android
  java               -            not installed 
  android home       -            undefined     

iOS
  xcode              16.1       
  cocoapods          1.16.2       /usr/local/bin/pod 

Tools
  git                git version 2.39.5 (Apple Git-154)   /usr/bin/git 
@JosephBarkate
Copy link
Author

I removed the entire folder and re-installed using yarn it seems to work without this previous issue. Feel free to close this ticket if not useful.

@frankcalise
Copy link
Contributor

frankcalise commented Dec 7, 2024

@JosephBarkate thanks for the report, I couldn't reproduce this - could you supply your new command for me?

EDIT: nevermind you took the defaults, let me try again

@frankcalise
Copy link
Contributor

Hmm yeah couldn't reproduce on node 20, wonder if it's specific to 21 and some npm upgrade (although I'm on 10.2.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants