feat(processing_engine): Have automatic plugin dir at /plugins for docker. #26047
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdstrand
reviewed
Feb 20, 2025
There was a problem hiding this comment.
There are conflicts that need to be resolved; curious, was this developed against main or #26042?
I saw this issue in my testing where I needed to chmod 775 my plugins dir and chgrp it to the gid in the container to be able to write out the .venv. I was somewhat surprised this would address the issue because I thought that docker would mount over /plugins in the container with the directory outside of the container. However, in thinking about it, docker is almost certainly using overlayfs here, which could make that work.
jacksonrnewhouse
force-pushed
the
auto_plugin_dir_docker
branch
from
04ac809 to
f669370
Compare
jdstrand
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @jdstrand got the venv stuff working in a different way than #26027, I thought I'd just pull this out. The main thing it does is ensure that /plugins is created in the docker images with the right permissions, which had been a pain point for users.