Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "contains_address" search field for NetworkV4 #372

Open
UvixCreative opened this issue Oct 2, 2023 · 1 comment · May be fixed by #373
Open

Support "contains_address" search field for NetworkV4 #372

UvixCreative opened this issue Oct 2, 2023 · 1 comment · May be fixed by #373

Comments

@UvixCreative
Copy link

It appears that the contains_address search field for NetworkV4 objects is not currently supported. When I tried to use this kwarg, the URL that was built for the request did not include the contains_address field.

I gave a quick look at the source code and tried to fix it by just adding contains_address to the _all_searchable_fields variable in the NetworkV4 class, but that doesn't appear to work.

@UvixCreative UvixCreative linked a pull request Oct 2, 2023 that will close this issue
@UvixCreative
Copy link
Author

If it's not obvious, I did some more digging and got it working in #373. I did not add this to NetworkV6 because, as far as I can tell from the WAPI documentation, IPv6 networks do not support contains_address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant