Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate filtering in Hermes #4052

Open
5 tasks
ljoss17 opened this issue Jun 20, 2024 · 2 comments
Open
5 tasks

Consolidate filtering in Hermes #4052

ljoss17 opened this issue Jun 20, 2024 · 2 comments
Labels
I: configuration Internal: related to Hermes configuration I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Milestone

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Jun 20, 2024

Proposal

Following this comment, #4041 (review), this issue will be used to discuss the filtering features in Hermes.

There have been multiple issues related to filtering in Hermes. There are multiple filtering features such as excluded packets by sequence, packet filter by channel and port, skip packets for a destination chain which is not configured.
These filtering features should be reviewed and improved if necessary.

In addition there are filter methods which are always enabled, https://github.com/informalsystems/hermes/blob/v1.9.0/crates/relayer/src/supervisor.rs#L317. These should either be used correctly or removed.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zmanian
Copy link

zmanian commented Jun 21, 2024

It should be possible to filter ACK packets by string size

@ljoss17
Copy link
Contributor Author

ljoss17 commented Jun 24, 2024

Hi @zmanian, thanks for the suggestion.
We currently have the possibility to filter ICS04 packets containing ICS20 packet data. This verifications is applied to both send and acks, and the configurations for these filters are the following:

When you say filtering by String size, do you have anything else in mind or are you referring to memo and receiver fields?

@romac romac added this to the v1.11 milestone Jul 8, 2024
@romac romac added I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product I: configuration Internal: related to Hermes configuration labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: configuration Internal: related to Hermes configuration I: logic Internal: related to the relaying logic O: usability Objective: cause to improve the user experience (UX) and ease using the product
Projects
Status: 🩹 Triage
Development

No branches or pull requests

3 participants