Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transfer test for multihop channel #4090

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Add transfer test for multihop channel #4090

merged 3 commits into from
Aug 12, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jul 17, 2024

Closes: #XXX

Description

This PR adds a test for a IBC transfer on a multihop channel.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from joaotav July 17, 2024 10:45
romac
romac approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@joaotav joaotav self-assigned this Jul 19, 2024
@joaotav joaotav added the O: multi-hop Related to ICS 033 Multi-Hop Channel label Jul 19, 2024
@joaotav
Copy link
Collaborator

joaotav commented Jul 19, 2024

Thanks Luca! I've assigned myself and will work on the necessary changes once I return.

@romac
Copy link
Member

romac commented Aug 7, 2024

@joaotav What changes are necessary before we can merge this?

@joaotav joaotav merged commit 8c37bd5 into joaotav/4084-multihop-packet-relaying Aug 12, 2024
25 of 26 checks passed
@joaotav joaotav deleted the luca_joss/add-multihop-relaying-test branch August 12, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

@joaotav joaotav joaotav approved these changes

Assignees

@joaotav joaotav

Labels
O: multi-hop Related to ICS 033 Multi-Hop Channel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljoss17 @joaotav @romac