chore: reduce eslint warnings (#553)

Author: gasp

package.json

@@ -90,7 +90,8 @@
     "clear": "rm -rf ./.cache ./dist ./build",
     "convert": "convert-resources --path-generated src/resources/old",
     "storybook": "start-storybook -p 6006 -s public",
-    "build-storybook": "build-storybook -s public"
+    "build-storybook": "build-storybook -s public",
+    "lint": "eslint src/"
   },
   "eslintConfig": {
     "extends": "react-app",

src/components/accessories/admission/admissionForm/AdmissionForm.tsx

@@ -1,7 +1,6 @@
 import { useFormik } from "formik";
 import get from "lodash.get";
 import has from "lodash.has";
-import isEmpty from "lodash.isempty";
 import moment from "moment";
 import React, { FC, useCallback, useEffect, useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";

src/components/accessories/autocompleteField/AutocompleteField.tsx

@@ -10,7 +10,7 @@ import React, {
 } from "react";
 import { DefaultOptionType, IProps } from "./types";
 import "./styles.scss";
-import { Trans, useTranslation } from "react-i18next";
+import { useTranslation } from "react-i18next";
 import {
   Autocomplete,
   createFilterOptions,

src/components/accessories/billTable/BillTable.tsx

@@ -30,7 +30,6 @@ import {
 import { Add, FilterList } from "@material-ui/icons";
 import PatientPicker from "../patientPicker/PatientPicker";
 import { useNavigate } from "react-router";
-import PatientAutocomplete from "../patientAutocomplete/PatientAutocomplete";
 import InfoBox from "../infoBox/InfoBox";
 
 export const BillTable: FC<IBillTableProps> = ({ fields }) => {

src/components/accessories/billTable/types.ts

@@ -30,3 +30,14 @@ export type BillFilterFormFieldName =
   | "status"
   | "month"
   | "year";
+
+  export type TBillDisplayData = {
+    id: string | number,
+    date: string,
+    patient: JSX.Element,
+    amount: string,
+    balance: string,
+    status: string,
+    patId: number | undefined,
+    lastPayment: string,
+  }

src/components/accessories/billTable/useFormatData.tsx

@@ -3,7 +3,7 @@ import { BillPaymentsDTO, FullBillDTO } from "../../../generated";
 import { renderDate } from "../../../libraries/formatUtils/dataFormatting";
 import { Link } from "react-router-dom";
 import React from "react";
-import { IStatus } from "./types";
+import { IStatus, TBillDisplayData } from "./types";
 import { currencyFormat } from "../../../libraries/formatUtils/currencyFormatting";
 
 const useFormatData = (
@@ -33,7 +33,7 @@ const useFormatData = (
     });
   };
 
-  let results = new Array();
+  let results: Array<TBillDisplayData> = [];
   if (data)
     results = data
       .filter(

src/components/accessories/dashboard/dashboardContent/filter/types.ts

@@ -1,5 +1,3 @@
-import { DateRange } from "@material-ui/pickers/DateRangePicker/RangeTypes";
-
 export type TViewType = "day" | "week" | "month" | "year" | "range";
 export type TPeriodType = "current" | "previous" | "last2" | "last3" | "custom";
 export interface IOwnProps {

src/components/accessories/dashboard/opds/opdsBySex/OpdBySex.tsx

@@ -4,15 +4,12 @@ import { IOwnProps } from "../types";
 import { useTranslation } from "react-i18next";
 import { useDispatch } from "react-redux";
 import { searchOpds } from "../../../../../state/opds/actions";
-import { useData } from "../useData";
 import { TDashboardCardOptionActions } from "../../card/types";
 import React from "react";
 import { DashboardCard } from "../../card/DashboardCard";
 import { Piechart } from "../../../charts/pie/Piechart";
 import { DataSummary } from "../../summary/DataSummary";
 import { Skeleton } from "@material-ui/lab";
-import { ListItemIcon } from "@material-ui/core";
-import { Description, PictureAsPdf, SaveAlt } from "@material-ui/icons";
 
 import "../../card/styles.scss";
 import { useOpdBySexData } from "../../../../../libraries/dashboardUtils/opds/useOpdBySexData";

src/components/accessories/dateField/types.ts

@@ -1,4 +1,3 @@
-import { PopperProps } from "@material-ui/core";
 import { DatePickerView } from "@material-ui/pickers";
 import { MuiTextFieldProps } from "@material-ui/pickers/_shared/PureDateInput";
 import { ComponentType } from "react";

src/components/accessories/dateRangeField/DateRangeField.tsx

@@ -1,9 +1,7 @@
-import React, { FunctionComponent, useEffect, useState } from "react";
+import React, { FunctionComponent } from "react";
 import {
-  DateRange,
   DesktopDateRangePicker,
   MobileDateRangePicker,
-  RangeInput,
 } from "@material-ui/pickers";
 import { IProps } from "./types";
 import "./styles.scss";

src/components/accessories/dateRangeField/types.ts

@@ -1,6 +1,6 @@
-import { DatePickerView, DateRange, RangeInput } from "@material-ui/pickers";
+import { DatePickerView, DateRange } from "@material-ui/pickers";
 import { MuiTextFieldProps } from "@material-ui/pickers/_shared/PureDateInput";
-import { ComponentType, ReactNode } from "react";
+import { ComponentType } from "react";
 import { FIELD_VALIDATION } from "../../../types";
 
 export interface IProps {

src/components/accessories/discharge/PatientDischarge.tsx

@@ -42,9 +42,6 @@ const PatientDischarge: FC = () => {
   const patient = useSelector(
     (state: IState) => state.patients.selectedPatient.data
   );
-  const username = useSelector(
-    (state: IState) => state.main.authentication.data?.username
-  );
 
   const dischargeStatus = useSelector<IState>(
     (state) => state.admissions.dischargePatient.status

src/components/accessories/extendedConfirmationDialog/types.ts

@@ -1,5 +1,3 @@
-import { ReactNode } from "react";
-
 export interface IProps {
   isOpen: boolean;
   title: string;

src/components/accessories/hospitalInfo/HospitalInfo.tsx

@@ -8,7 +8,7 @@ import { useDispatch, useSelector } from "react-redux";
 import { getHospital } from "../../../state/hospital/actions";
 import { HospitalDTO } from "../../../generated";
 
-export const HospitalInfo: FC<TProps> = ({}) => {
+export const HospitalInfo: FC<TProps> = () => {
   const dispatch = useDispatch();
   const { t } = useTranslation();
   useEffect(() => {

src/components/accessories/hospitalInfo/types.ts

@@ -1,6 +1,3 @@
-import { TUserCredentials } from "../../../state/main/types";
-import { TAPIResponseStatus } from "../../../state/types";
-
 export type TBreadcrumbMap = Record<string, string>;
 
 export interface IOwnProps {}

src/components/accessories/laboratory/Exams.tsx

@@ -1,5 +1,4 @@
-import { Button, CircularProgress } from "@material-ui/core";
-import { Add } from "@material-ui/icons";
+import { CircularProgress } from "@material-ui/core";
 import React, { FC, Fragment, useMemo, useState, useRef } from "react";
 import { useTranslation } from "react-i18next";
 import { useDispatch, useSelector } from "react-redux";
@@ -28,8 +27,6 @@ import { getExams } from "../../../state/exams/actions";
 import { ILaboratoriesState } from "../../../state/laboratories/types";
 import { LaboratoryDTO, LaboratoryDTOStatusEnum } from "../../../generated";
 import ConfirmationDialog from "../confirmationDialog/ConfirmationDialog";
-import { getPatientThunk } from "../../../state/patients/actions";
-import isEmpty from "lodash.isempty";
 import { EditLaboratoryContent } from "./EditLaboratoryContent";
 import { PATHS } from "../../../consts";
 import { Permission } from "../../../libraries/permissionUtils/Permission";

src/components/accessories/laboratory/examForm/ExamForm.tsx

@@ -210,9 +210,6 @@ const ExamForm: FC<ExamProps> = ({
   };
 
   const examList = useSelector((state: IState) => state.exams.examList.data);
-  const materialsList = useSelector(
-    (state: IState) => state.laboratories.materials.data
-  );
 
   const examRowOptionsSelector = (state: IState) => {
     if (state.exams.examRowsByExamCode.data) {
@@ -345,10 +342,6 @@ const ExamForm: FC<ExamProps> = ({
     (state: IState) => state.exams.examList.status === "LOADING"
   );
 
-  const materialsLoading = useSelector(
-    (state: IState) => state.laboratories.materials.status === "LOADING"
-  );
-
   const isLoading =
     labStore.createLab.status === "LOADING" ||
     labStore.updateLab.status === "LOADING";

src/components/accessories/laboratory/filter/ExamFilterForm.tsx

@@ -12,7 +12,7 @@ import has from "lodash.has";
 import React, { useCallback, useState } from "react";
 import { FC } from "react";
 import { useTranslation } from "react-i18next";
-import { number, object, string } from "yup";
+import { object, string } from "yup";
 import {
   ExamDTO,
   LaboratoryDTOStatusEnum,
@@ -29,7 +29,6 @@ import DateField from "../../dateField/DateField";
 import PatientPicker from "../../patientPicker/PatientPicker";
 import { IExamFilterProps, TFilterValues } from "./types";
 import "./styles.scss";
-import { isEmpty } from "lodash";
 import AutocompleteField from "../../autocompleteField/AutocompleteField";
 import { IState } from "../../../../types";
 import { useSelector } from "react-redux";

src/components/accessories/opds/table/types.ts

@@ -1,4 +1,3 @@
-import { number } from "yup";
 import { OpdDTO } from "../../../../generated";
 
 export interface IOpdTableProps {

src/components/accessories/patientNewBill/itemPayment/ItemPayment.tsx

@@ -37,7 +37,7 @@ const ItemPayment: FC<IOwnProps> = ({
         <span>{currencyFormat(billTotal - paymentTotal)}</span>
       </div>
       <div className="payment__buttons">
-        {(billTotal > 0 && billTotal - paymentTotal == 0 && (
+        {(billTotal > 0 && billTotal - paymentTotal === 0 && (
           <div>
             <Button
               className={"paid"}

src/components/accessories/patientNewBill/itemPicker/BillItemPicker.tsx

@@ -1,17 +1,11 @@
 import { FormControlLabel, Radio, RadioGroup } from "@material-ui/core";
-import { useFormik } from "formik";
+
 import React, { FC, useCallback, useEffect, useMemo, useState } from "react";
 import { useTranslation } from "react-i18next";
-import { number, object, string } from "yup";
-import { BillItemsDTO } from "../../../../generated";
 import { PriceDTO } from "../../../../generated/models/PriceDTO";
-import {
-  formatAllFieldValues,
-  getFromFields,
-} from "../../../../libraries/formDataHandling/functions";
+import { formatAllFieldValues } from "../../../../libraries/formDataHandling/functions";
 import AutocompleteField from "../../autocompleteField/AutocompleteField";
 import SmallButton from "../../smallButton/SmallButton";
-import TextButton from "../../textButton/TextButton";
 import TextField from "../../textField/TextField";
 import { ItemGroups } from "../consts";
 import { useItemPrices } from "../hooks/price.hooks";
@@ -51,7 +45,7 @@ const BillItemPickerForm: FC<BillItemProps> = ({
       if (itemType == ItemGroups.other.id) {
         item.itemAmount = values?.itemAmount;
         item.itemDescription = values?.itemDescription;
-        onSubmit(item, itemToEdit == undefined ? true : false);
+        onSubmit(item, itemToEdit === undefined ? true : false);
         return;
       }
       let priceDTO: PriceDTO | undefined = prices.find(
@@ -64,7 +58,7 @@ const BillItemPickerForm: FC<BillItemProps> = ({
         item.itemId = priceDTO.item;
         item.price = true;
         item.priceId = priceDTO.id?.toString() ?? "";
-        onSubmit(item, itemToEdit == undefined ? true : false);
+        onSubmit(item, itemToEdit === undefined ? true : false);
       }
     },
     [itemType]
@@ -73,7 +67,6 @@ const BillItemPickerForm: FC<BillItemProps> = ({
   const {
     getErrorText,
     getFieldProps,
-    handleResetConfirmation,
     onBlurCallback,
     handleBlur,
     isValid,

src/components/accessories/patientNewBill/itemsTable/BillItemsTable.tsx

@@ -1,7 +1,6 @@
 import React, { FC } from "react";
 import Table from "../../table/Table";
 import { header, order } from "./consts";
-import { currencyFormat } from "../../../../libraries/formatUtils/currencyFormatting";
 import { useTranslation } from "react-i18next";
 
 interface IOwnProps {

src/components/activities/loginActivity/RedirectAfterLogin.tsx

@@ -2,7 +2,6 @@ import React, { useMemo } from "react";
 import { useSelector } from "react-redux";
 import { Navigate, useLocation } from "react-router";
 import { useLandingPageRoute } from "../../../libraries/hooks/useLandingPageRoute";
-import { TAPIResponseStatus } from "../../../state/types";
 import { IState } from "../../../types";
 import { IRedirectAfterLogin } from "./types";
 

src/components/activities/newPatientActivity/NewPatientActivity.tsx

@@ -56,10 +56,6 @@ const NewPatientActivity: FunctionComponent<TProps> = ({
       state.patients.createPatient.error?.message || t("common.somethingwrong")
   );
 
-  const selectedPatient = useSelector<IState, PatientDTO | undefined>(
-    (state) => state.patients.selectedPatient.data
-  );
-
   const patient = useSelector<IState, PatientDTO | undefined>(
     (state) =>
       state.patients.createPatient.data || state.patients.updatePatient.data

src/generated/models/Patient.ts

@@ -195,10 +195,10 @@ export interface Patient {
      * @type {string}
      * @memberof Patient
      */
-    searchString?: string;
+    informations?: string;
     /**
      * @type {string}
      * @memberof Patient
      */
-    informations?: string;
+    searchString?: string;
 }

src/generated/models/TherapyRow.ts

@@ -105,11 +105,6 @@ export interface TherapyRow {
      * @memberof TherapyRow
      */
     smsInt: number;
-    /**
-     * @type {number}
-     * @memberof TherapyRow
-     */
-    medical?: number;
     /**
      * @type {boolean}
      * @memberof TherapyRow
@@ -120,4 +115,9 @@ export interface TherapyRow {
      * @memberof TherapyRow
      */
     sms?: boolean;
+    /**
+     * @type {number}
+     * @memberof TherapyRow
+     */
+    medical?: number;
 }