Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer hangs if file cannot be accessed #47

Open
carlkesselman opened this issue Jan 24, 2019 · 2 comments
Open

Viewer hangs if file cannot be accessed #47

carlkesselman opened this issue Jan 24, 2019 · 2 comments
Assignees

Comments

@carlkesselman
Copy link

It looks like the viewer doesn't respond to a 401 return in a nice way.

JavaScript console shows:

[Error] Failed to load resource: the server responded with a status of 401 () (RID,url,filename,label,description,color_r:=model_mesh:color_r,color_g:=model_mesh:color_g,color_b:=model_mesh:color_b,opacity:=model_mesh:opacity, line 0)

View is hanging showing message "Loading Data".

Checking the requested resource directly, I get:
401 Unauthorized
The requested select access on :viz:model:RID is forbidden.

I would think that you should get some kind of error popup or something like that in the case where one of the URLs fails to respond in the expected manner.

@NickolausDS
Copy link
Collaborator

This would be a good feature to have. It's on my list, but I'm currently prioritizing the Minid Client release ahead of this. I should be able to start on it the end of this week or the beginning of the next.

@NickolausDS
Copy link
Collaborator

The PR updates the message when there is an error, and additionally provides some better debugging info so you can see which param failed, what it tried to fetch (unquoted), and what JSON it returned (If the server did return JSON but contained errors). Here's a screenshot of a bad fetch:

screen shot 2019-02-15 at 11 02 12 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants