Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log full error message returned from OAuth service providers #62

Open
robes opened this issue Jul 25, 2017 · 3 comments
Open

Log full error message returned from OAuth service providers #62

robes opened this issue Jul 25, 2017 · 3 comments
Assignees

Comments

@robes
Copy link
Contributor

robes commented Jul 25, 2017

In our recently encountered errors in the OAuth authentication flow with Globus, we got back an error from Globus but didn't log the full error message. This limited our ability to report more details and debug fully.

@karlcz
Copy link
Contributor

karlcz commented Jul 25, 2017

I think you're talking about this kind of failure observed in some of our systems 2017-07-17:

Got <class 'urllib2.HTTPError'> exception HTTP Error 401: Unauthorized while getting token (url https://auth.globus.org/v2/oauth2/token...

which is coming out of:

File "/usr/lib/python2.7/site-packages/webauthn2/providers/oauth2.py", line 401, in open_url

is that correct?

@robes
Copy link
Contributor Author

robes commented Jul 25, 2017

That's correct.

@ljpearlman
Copy link
Contributor

I don't think there's any additional information to log. I believe people thought there was because the logs include the amount of data sent with the request, and people thought that was the amount of data received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants