Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[overlays] nested overlays having preventsScroll:true should not accumulate margins #2349

Open
tlouisse opened this issue Aug 27, 2024 · 0 comments

Comments

@tlouisse
Copy link
Member

Expected behavior

A clear and concise description of what you expected to happen.

Actual Behavior

Right now, all types of overlays add body margin. This should only happen for modal like overlays (preventsScroll: true).
This PR tackles that: #2331

However, it can still happen multiple overlays having preventsScroll: true are nested. Accumulation would still happen.

Solution

Interacting with the window/body should be handled on OverlaysManager (singleton) level. When the OverlaysManager detects another overlay is already handling body margin, it should keep margin as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant