Merge pull request #2 from ingenerator/0.1/validate-number

Add ValidNumber with ::minimum() validator

Author: acoulton

CHANGELOG.md

@@ -1,5 +1,9 @@
 ### Unreleased
 
+### v0.1.3 (2018-02-22)
+
+* Extract the basic ValidNumber class for validating minimum
+
 ### v0.1.2 (2018-02-13)
 
 * Fix signature of InvalidUserDateTime::createFromMutable for PHP >= 5.6 compatibility

src/Validation/ValidNumber.php

@@ -0,0 +1,42 @@
+<?php
+/**
+ * @author    Andrew Coulton <andrew@ingenerator.com>
+ * @licence   proprietary
+ */
+
+namespace Ingenerator\PHPUtils\Validation;
+
+
+class ValidNumber
+{
+    protected function __construct() { }
+
+    /**
+     * @param string    $number
+     * @param int|float $min
+     *
+     * @return bool
+     */
+    public static function minimum($number, $min)
+    {
+        return ($number >= $min);
+    }
+
+    /**
+     * Shorthand way to specify the fully qualified validator callback
+     *
+     * @param string $rulename
+     *
+     * @return string
+     */
+    public static function rule($rulename)
+    {
+        switch ($rulename) {
+            case 'minimum':
+                return static::class.'::'.$rulename;
+            default:
+                throw new \InvalidArgumentException('Unknown rule '.__CLASS__.'::'.$rulename);
+        }
+    }
+
+}

test/unit/Validation/ValidNumberTest.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ * @author    Andrew Coulton <andrew@ingenerator.com>
+ * @licence   proprietary
+ */
+
+namespace test\unit\Ingenerator\PHPUtils\Validation;
+
+
+use Ingenerator\PHPUtils\Validation\ValidNumber;
+
+class ValidNumberTest extends \PHPUnit_Framework_TestCase
+{
+
+    /**
+     * @testWith ["", false]
+     *           ["junk", false]
+     *           ["0", false]
+     *           ["12", false]
+     *           ["13", true]
+     *           [18, true]
+     */
+    public function test_it_validates_minimum_as_greater_or_equal($value, $expect)
+    {
+        $this->assertSame($expect, ValidNumber::minimum($value, 13));
+    }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     */
+    public function test_it_throws_for_unknown_rule_name()
+    {
+        ValidNumber::rule('random nonsense');
+    }
+
+    public function test_it_returns_validator_name()
+    {
+        $this->assertSame(
+            'Ingenerator\PHPUtils\Validation\ValidNumber::minimum',
+            ValidNumber::rule('minimum')
+        );
+    }
+
+}