Skip to content

Commit 7e92c33

Browse files
authored
Merge pull request #198 from inha-iesw/feat/#197
feat/#197: 페이징 조회 시 사이즈 입력받도록 변경
2 parents bceb703 + 581f48d commit 7e92c33

File tree

9 files changed

+39
-16
lines changed

9 files changed

+39
-16
lines changed

src/main/java/inha/git/notice/api/controller/NoticeController.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,19 @@ public class NoticeController {
4343
* <p>공지를 조회.</p>
4444
*
4545
* @param page 페이지 번호
46-
*
46+
* @param size 페이지 사이즈
4747
* @return 공지 조회 결과를 포함하는 BaseResponse<Page<SearchNoticeResponse>>
4848
*/
4949
@GetMapping
5050
@Operation(summary = "공지 조회 API", description = "공지를 조회합니다.")
51-
public BaseResponse<Page<SearchNoticesResponse>> getNotices(@RequestParam("page") Integer page) {
51+
public BaseResponse<Page<SearchNoticesResponse>> getNotices(@RequestParam("page") Integer page, @RequestParam("size") Integer size) {
5252
if (page < 1) {
5353
throw new BaseException(INVALID_PAGE);
5454
}
55-
return BaseResponse.of(NOTICE_SEARCH_OK, noticeService.getNotices(page - 1));
55+
if (size < 1) {
56+
throw new BaseException(INVALID_PAGE);
57+
}
58+
return BaseResponse.of(NOTICE_SEARCH_OK, noticeService.getNotices(page - 1, size - 1));
5659
}
5760

5861
/**

src/main/java/inha/git/notice/api/service/NoticeService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import java.util.List;
1212

1313
public interface NoticeService {
14-
Page<SearchNoticesResponse> getNotices(Integer page);
14+
Page<SearchNoticesResponse> getNotices(Integer page, Integer size);
1515
String createNotice(User user, CreateNoticeRequest createNoticeRequest, List<MultipartFile> attachmentList);
1616

1717
String updateNotice(User user, Integer noticeIdx, UpdateNoticeRequest updateNoticeRequest, List<MultipartFile> attachmentList);

src/main/java/inha/git/notice/api/service/NoticeServiceImpl.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,13 @@ public class NoticeServiceImpl implements NoticeService {
5858
* 공지 조회
5959
*
6060
* @param page 페이지 번호
61+
* @param size 페이지 사이즈
6162
* @return 공지 페이지
6263
*/
6364
@Override
6465
@Transactional(readOnly = true)
65-
public Page<SearchNoticesResponse> getNotices(Integer page) {
66-
Pageable pageable = PageRequest.of(page, 10, Sort.by(Sort.Direction.DESC, CREATE_AT));
66+
public Page<SearchNoticesResponse> getNotices(Integer page, Integer size) {
67+
Pageable pageable = PageRequest.of(page, size, Sort.by(Sort.Direction.DESC, CREATE_AT));
6768
return noticeQueryRepository.getNotices(pageable);
6869
}
6970

src/main/java/inha/git/problem/api/controller/ProblemController.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,26 @@ public class ProblemController {
3737

3838
private final ProblemService problemService;
3939

40+
/**
41+
* 문제 목록 조회 API
42+
*
43+
* <p>문제 목록을 조회합니다.</p>
44+
*
45+
* @param page 페이지 번호
46+
* @param size 페이지 사이즈
47+
* @return 문제 목록 조회 결과를 포함하는 BaseResponse<Page<SearchProblemsResponse>>
48+
*/
4049
@GetMapping
4150
@Operation(summary = "문제 목록 조회 API", description = "문제 목록을 조회합니다.")
42-
public BaseResponse<Page<SearchProblemsResponse>> getProblems(@RequestParam("page") Integer page) {
51+
public BaseResponse<Page<SearchProblemsResponse>> getProblems(@RequestParam("page") Integer page,
52+
@RequestParam("size") Integer size) {
4353
if (page < 1) {
4454
throw new BaseException(INVALID_PAGE);
4555
}
46-
return BaseResponse.of(PROBLEM_SEARCH_OK, problemService.getProblems(page - 1));
56+
if (size < 1) {
57+
throw new BaseException(INVALID_PAGE);
58+
}
59+
return BaseResponse.of(PROBLEM_SEARCH_OK, problemService.getProblems(page - 1, size - 1));
4760
}
4861

4962
/**

src/main/java/inha/git/problem/api/service/ProblemService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import java.util.List;
1010

1111
public interface ProblemService {
12-
Page<SearchProblemsResponse> getProblems(Integer page);
12+
Page<SearchProblemsResponse> getProblems(Integer page, Integer size);
1313
SearchProblemResponse getProblem(Integer problemIdx);
1414
ProblemResponse createProblem(User user, CreateProblemRequest createProblemRequest, MultipartFile file);
1515
ProblemResponse updateProblem(User user, Integer problemIdx, UpdateProblemRequest updateProblemRequest, MultipartFile file);

src/main/java/inha/git/problem/api/service/ProblemServiceImpl.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,12 @@ public class ProblemServiceImpl implements ProblemService {
6060
* 문제 목록 조회
6161
*
6262
* @param page 페이지
63+
* @param size 사이즈
6364
* @return 문제 목록
6465
*/
6566
@Override
66-
public Page<SearchProblemsResponse> getProblems(Integer page) {
67-
Pageable pageable = PageRequest.of(page, 10, Sort.by(Sort.Direction.DESC, CREATE_AT));
67+
public Page<SearchProblemsResponse> getProblems(Integer page, Integer size) {
68+
Pageable pageable = PageRequest.of(page, size, Sort.by(Sort.Direction.DESC, CREATE_AT));
6869
return problemQueryRepository.getProblems(pageable);
6970
}
7071

src/main/java/inha/git/project/api/controller/ProjectController.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,19 @@ public class ProjectController {
5353
* <p>프로젝트 전체를 조회합니다.</p>
5454
*
5555
* @param page 페이지 번호
56+
* @param size 페이지 사이즈
5657
* @return 검색된 프로젝트 정보를 포함하는 BaseResponse<Page<SearchProjectsResponse>>
5758
*/
5859
@GetMapping
5960
@Operation(summary = "프로젝트 전체 조회 API", description = "프로젝트 전체를 조회합니다.")
60-
public BaseResponse<Page<SearchProjectsResponse>> getProjects(@RequestParam("page") Integer page) {
61+
public BaseResponse<Page<SearchProjectsResponse>> getProjects(@RequestParam("page") Integer page, @RequestParam("size") Integer size) {
6162
if (page < 1) {
6263
throw new BaseException(INVALID_PAGE);
6364
}
64-
return BaseResponse.of(PROJECT_SEARCH_OK, projectSearchService.getProjects(page - 1));
65+
if (size < 1) {
66+
throw new BaseException(INVALID_PAGE);
67+
}
68+
return BaseResponse.of(PROJECT_SEARCH_OK, projectSearchService.getProjects(page - 1, size - 1));
6569
}
6670

6771
/**

src/main/java/inha/git/project/api/service/ProjectSearchService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
public interface ProjectSearchService {
1313

14-
Page<SearchProjectsResponse> getProjects(Integer page);
14+
Page<SearchProjectsResponse> getProjects(Integer page, Integer size);
1515
Page<SearchProjectsResponse> getCondProjects(SearchProjectCond searchProjectCond, Integer page);
1616
SearchProjectResponse getProject(User user, Integer projectIdx);
1717

src/main/java/inha/git/project/api/service/ProjectSearchServiceImpl.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,12 @@ public class ProjectSearchServiceImpl implements ProjectSearchService {
6868
* 프로젝트 전체 조회
6969
*
7070
* @param page 페이지 번호
71+
* @param size 페이지 사이즈
7172
* @return 검색된 프로젝트 정보 페이지
7273
*/
7374
@Override
74-
public Page<SearchProjectsResponse> getProjects(Integer page) {
75-
Pageable pageable = PageRequest.of(page, 10, Sort.by(Sort.Direction.DESC, CREATE_AT));
75+
public Page<SearchProjectsResponse> getProjects(Integer page, Integer size) {
76+
Pageable pageable = PageRequest.of(page, size, Sort.by(Sort.Direction.DESC, CREATE_AT));
7677
return projectQueryRepository.getProjects(pageable);
7778
}
7879

0 commit comments

Comments
 (0)