format

Author: fb55

bench/perf/index.js

@@ -15,15 +15,15 @@ const saxPath = new URL('../../test/data/sax/', import.meta.url);
 
 //HACK: https://github.com/bestiejs/benchmark.js/issues/51
 /* global workingCopy, WorkingCopyParserStream, upstreamParser, hugePage, microTests, runMicro, runPages, files */
-global.workingCopy = parse5;
-global.WorkingCopyParserStream = parse5Stream;
-global.upstreamParser = parse5Upstream;
+globalThis.workingCopy = parse5;
+globalThis.WorkingCopyParserStream = parse5Stream;
+globalThis.upstreamParser = parse5Upstream;
 
 // Huge page data
-global.hugePage = readFileSync(hugePagePath).toString();
+globalThis.hugePage = readFileSync(hugePagePath).toString();
 
 // Micro data
-global.microTests = loadTreeConstructionTestData(treeConstructionPath, treeAdapters.default)
+globalThis.microTests = loadTreeConstructionTestData(treeConstructionPath, treeAdapters.default)
     .filter(
         (test) =>
             //NOTE: this test caused a stack overflow in parse5 v1.x
@@ -34,7 +34,7 @@ global.microTests = loadTreeConstructionTestData(treeConstructionPath, treeAdapt
         fragmentContext: test.fragmentContext,
     }));
 
-global.runMicro = function (parser) {
+globalThis.runMicro = function (parser) {
     for (const test of microTests) {
         if (test.fragmentContext) {
             parser.parseFragment(test.fragmentContext, test.html);
@@ -47,14 +47,14 @@ global.runMicro = function (parser) {
 // Pages data
 const pages = loadSAXParserTestData().map((test) => test.src);
 
-global.runPages = function (parser) {
+globalThis.runPages = function (parser) {
     for (const page of pages) {
         parser.parse(page);
     }
 };
 
 // Stream data
-global.files = readdirSync(saxPath).map((dirName) => new URL(`${dirName}/src.html`, saxPath).pathname);
+globalThis.files = readdirSync(saxPath).map((dirName) => new URL(`${dirName}/src.html`, saxPath).pathname);
 
 // Utils
 function getHz(suite, testName) {

package-lock.json

@@ -122,7 +122,7 @@ export class FormattingElementList<T extends TreeAdapterTypeMap> {
     removeEntry(entry: Entry<T>): void {
         const entryIndex = this.entries.indexOf(entry);
 
-        if (entryIndex >= 0) {
+        if (entryIndex !== -1) {
             this.entries.splice(entryIndex, 1);
         }
     }
@@ -135,10 +135,10 @@ export class FormattingElementList<T extends TreeAdapterTypeMap> {
     clearToLastMarker(): void {
         const markerIdx = this.entries.indexOf(MARKER);
 
-        if (markerIdx >= 0) {
-            this.entries.splice(0, markerIdx + 1);
-        } else {
+        if (markerIdx === -1) {
             this.entries.length = 0;
+        } else {
+            this.entries.splice(0, markerIdx + 1);
         }
     }
 

packages/parse5/lib/parser/formatting-element-list.ts

@@ -643,7 +643,7 @@ export class Parser<T extends TreeAdapterTypeMap> implements TokenHandler, Stack
                 (entry) => entry.type === EntryType.Marker || this.openElements.contains(entry.element),
             );
 
-            const unopenIdx = endIndex < 0 ? listLength - 1 : endIndex - 1;
+            const unopenIdx = endIndex === -1 ? listLength - 1 : endIndex - 1;
 
             for (let i = unopenIdx; i >= 0; i--) {
                 const entry = this.activeFormattingElements.entries[i] as ElementEntry<T>;
@@ -1419,7 +1419,7 @@ function aaObtainFurthestBlock<T extends TreeAdapterTypeMap>(
     }
 
     if (!furthestBlock) {
-        p.openElements.shortenToLength(idx < 0 ? 0 : idx);
+        p.openElements.shortenToLength(Math.max(idx, 0));
         p.activeFormattingElements.removeEntry(formattingElementEntry);
     }
 

packages/parse5/lib/parser/index.ts

@@ -136,7 +136,7 @@ export class OpenElementStack<T extends TreeAdapterTypeMap> {
             targetIdx = this.tagIDs.lastIndexOf(tagName, targetIdx - 1);
         } while (targetIdx > 0 && this.treeAdapter.getNamespaceURI(this.items[targetIdx]) !== NS.HTML);
 
-        this.shortenToLength(targetIdx < 0 ? 0 : targetIdx);
+        this.shortenToLength(Math.max(targetIdx, 0));
     }
 
     shortenToLength(idx: number): void {
@@ -156,12 +156,12 @@ export class OpenElementStack<T extends TreeAdapterTypeMap> {
 
     popUntilElementPopped(element: T['element']): void {
         const idx = this._indexOf(element);
-        this.shortenToLength(idx < 0 ? 0 : idx);
+        this.shortenToLength(Math.max(idx, 0));
     }
 
     private popUntilPopped(tagNames: Set<$>, targetNS: NS): void {
         const idx = this._indexOfTagNames(tagNames, targetNS);
-        this.shortenToLength(idx < 0 ? 0 : idx);
+        this.shortenToLength(Math.max(idx, 0));
     }
 
     popUntilNumberedHeaderPopped(): void {