From d2d65a78c6a7bfdeccbd29616ac6770ab4ff7d7c Mon Sep 17 00:00:00 2001 From: Gabriel Pessoa Date: Fri, 17 Nov 2023 11:26:43 -0300 Subject: [PATCH] Remove installation id from register web login --- README.md | 1 - src/main/java/com/incognia/api/IncogniaAPI.java | 3 --- .../incognia/transaction/login/RegisterWebLoginRequest.java | 1 - src/test/java/com/incognia/api/IncogniaAPITest.java | 3 --- 4 files changed, 8 deletions(-) diff --git a/README.md b/README.md index 0b9c31d..52eeee8 100644 --- a/README.md +++ b/README.md @@ -150,7 +150,6 @@ IncogniaAPI api = new IncogniaAPI("client-id", "client-secret"); try { RegisterLoginRequest registerLoginRequest = RegisterLoginRequest.builder() - .installationId("installation id") .accountId("account id") .externalId("external id") .sessionToken("session-token") diff --git a/src/main/java/com/incognia/api/IncogniaAPI.java b/src/main/java/com/incognia/api/IncogniaAPI.java index e7ebb27..b9a7147 100644 --- a/src/main/java/com/incognia/api/IncogniaAPI.java +++ b/src/main/java/com/incognia/api/IncogniaAPI.java @@ -209,7 +209,6 @@ public TransactionAssessment registerLogin(RegisterLoginRequest request) * IncogniaAPI api = new IncogniaAPI("client-id", "client-secret", Region.BR); * try { * RegisterLoginRequest loginRequest = RegisterLoginRequest.builder() - * .installationId("installation-id") * .accountId("account-id") * .externalId("external-id") * .sessionToken("session-token") @@ -232,12 +231,10 @@ public TransactionAssessment registerLogin(RegisterLoginRequest request) public TransactionAssessment registerWebLogin(RegisterWebLoginRequest request) throws IncogniaException { Asserts.assertNotNull(request, "register login request"); - Asserts.assertNotEmpty(request.getInstallationId(), "installation id"); Asserts.assertNotEmpty(request.getAccountId(), "account id"); Asserts.assertNotEmpty(request.getSessionToken(), "session token"); PostTransactionRequestBody requestBody = PostTransactionRequestBody.builder() - .installationId(request.getInstallationId()) .accountId(request.getAccountId()) .externalId(request.getExternalId()) .sessionToken(request.getSessionToken()) diff --git a/src/main/java/com/incognia/transaction/login/RegisterWebLoginRequest.java b/src/main/java/com/incognia/transaction/login/RegisterWebLoginRequest.java index 3c43b1a..681cf4c 100644 --- a/src/main/java/com/incognia/transaction/login/RegisterWebLoginRequest.java +++ b/src/main/java/com/incognia/transaction/login/RegisterWebLoginRequest.java @@ -8,7 +8,6 @@ @Value @Builder public class RegisterWebLoginRequest { - String installationId; String accountId; String externalId; String sessionToken; diff --git a/src/test/java/com/incognia/api/IncogniaAPITest.java b/src/test/java/com/incognia/api/IncogniaAPITest.java index d902724..179fcd9 100644 --- a/src/test/java/com/incognia/api/IncogniaAPITest.java +++ b/src/test/java/com/incognia/api/IncogniaAPITest.java @@ -227,7 +227,6 @@ void testRegisterLogin_whenDataIsValid(Boolean eval) { @SneakyThrows void testRegisterWebLogin_whenDataIsValid(Boolean eval) { String token = TokenCreationFixture.createToken(); - String installationId = "installation-id"; String accountId = "account-id"; String externalId = "external-id"; String sessionToken = "session-token"; @@ -235,7 +234,6 @@ void testRegisterWebLogin_whenDataIsValid(Boolean eval) { TokenAwareDispatcher dispatcher = new TokenAwareDispatcher(token, CLIENT_ID, CLIENT_SECRET); dispatcher.setExpectedTransactionRequestBody( PostTransactionRequestBody.builder() - .installationId(installationId) .externalId(externalId) .accountId(accountId) .type("login") @@ -246,7 +244,6 @@ void testRegisterWebLogin_whenDataIsValid(Boolean eval) { mockServer.setDispatcher(dispatcher); RegisterWebLoginRequest loginRequest = RegisterWebLoginRequest.builder() - .installationId(installationId) .accountId(accountId) .externalId(externalId) .evaluateTransaction(eval)