Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle exceptions when permanently storing a video and its thumbnails #17

Open
daniil-berg opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
consistency An inconsistency that should be (re-)aligned enhancement New feature or request error handling More helpful and transparent error handling/logging

Comments

@daniil-berg
Copy link
Contributor

The StorageFileController.store_permanently method currently does not catch errors, when .store_file_permanently is called with the video path, but does so and swallows them, what that same method is called with the thumbnail paths.

The entire operation should probably be atomic in that either both video and thumbnails are successfully stored or neither is, but I am not sure how feasible a robust rollback mechanism is in this case.

Whether errors should be propagated or simply logged, it should be done consistently for video and thumbnails.

@daniil-berg daniil-berg self-assigned this Sep 13, 2024
@daniil-berg daniil-berg changed the title Properly handle exceptions when permanently storing a video and it thumbnails Properly handle exceptions when permanently storing a video and its thumbnails Sep 16, 2024
@daniil-berg daniil-berg added enhancement New feature or request consistency An inconsistency that should be (re-)aligned error handling More helpful and transparent error handling/logging labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency An inconsistency that should be (re-)aligned enhancement New feature or request error handling More helpful and transparent error handling/logging
Projects
None yet
Development

No branches or pull requests

1 participant