From dfb066eb70476eaddd9fdbc78a6a477ebac9e851 Mon Sep 17 00:00:00 2001
From: iquerejeta <querejeta.azurmendi@iohk.io>
Date: Mon, 21 Oct 2024 18:24:18 +0200
Subject: [PATCH] Default without compress selectors

---
 halo2_proofs/src/plonk.rs        | 4 ++++
 halo2_proofs/src/plonk/keygen.rs | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/halo2_proofs/src/plonk.rs b/halo2_proofs/src/plonk.rs
index 05ff8c0dd7..723c9aeacd 100644
--- a/halo2_proofs/src/plonk.rs
+++ b/halo2_proofs/src/plonk.rs
@@ -55,6 +55,10 @@ where
     #[cfg(not(feature = "circuit-params"))]
     ConcreteCircuit::configure(&mut cs);
 
+    // we still need to replace selectors with fixed Expressions in `cs`
+    let fake_selectors = vec![vec![]; cs.num_selectors()];
+    let (cs, _) = cs.directly_convert_selectors_to_fixed(fake_selectors);
+
     let cs_mid: ConstraintSystemMid<_> = cs.into();
     VerifyingKey::read(reader, format, cs_mid.into())
 }
diff --git a/halo2_proofs/src/plonk/keygen.rs b/halo2_proofs/src/plonk/keygen.rs
index 9bdffcb84f..58e49390de 100644
--- a/halo2_proofs/src/plonk/keygen.rs
+++ b/halo2_proofs/src/plonk/keygen.rs
@@ -24,7 +24,7 @@ where
     ConcreteCircuit: Circuit<C::Scalar>,
     C::Scalar: FromUniformBytes<64>,
 {
-    keygen_vk_custom(params, circuit, true)
+    keygen_vk_custom(params, circuit, false)
 }
 
 /// Generate a `VerifyingKey` from an instance of `Circuit`.
@@ -66,7 +66,7 @@ where
     P: Params<C>,
     ConcreteCircuit: Circuit<C::Scalar>,
 {
-    keygen_pk_custom(params, vk, circuit, true)
+    keygen_pk_custom(params, vk, circuit, false)
 }
 
 /// Generate a `ProvingKey` from an instance of `Circuit`.