Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: roxy.shinylive is not included in .pre-commit-config.yaml #85

Closed
3 tasks done
averissimo opened this issue Nov 1, 2024 · 1 comment · Fixed by insightsengineering/teal.modules.general#793 or insightsengineering/teal.modules.clinical#1238
Closed
3 tasks done

[Bug]: roxy.shinylive is not included in .pre-commit-config.yaml #85

averissimo opened this issue Nov 1, 2024 · 1 comment · Fixed by insightsengineering/teal.modules.general#793 or insightsengineering/teal.modules.clinical#1238
Assignees
@averissimo
Labels
bug Something isn't working core

Comments

@averissimo
Copy link

averissimo commented Nov 1, 2024 •
edited
Loading

What happened?

precommit hook fails when this dependency is not on .pre-commit-config.yaml file

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@averissimo averissimo added bug Something isn't working core labels Nov 1, 2024
This was referenced Nov 1, 2024
Merged
Merged
@pawelru pawelru assigned averissimo and unassigned donyunardi, pawelru and cicdguy Nov 1, 2024
@averissimo
Copy link
Author

The 2 PRs still fail with the currently released hooks in version v0.4.3.9001

It uses a PPM version from September, but {roxy.shinylive} requires a dependency released in October ({lzstring} 0.1.2 vs 0.1.3)

We can mitigate by setting export RENV_CONFIG_REPOS_OVERRIDE=https://packagemanager.posit.co/cran/2024-10-28, before commiting.

Should we merge the PRs or just wait until the precommit is updated? I asked the maintainer what's the timeline

averissimo added a commit to insightsengineering/teal.modules.clinical that referenced this issue Nov 4, 2024
@averissimo
Adds roxy.shinylive to pre-commit configuration (#1238)
5b91926 
# Pull Request

<!--- Replace `#nnn` with your issue link for reference. -->

Fixes insightsengineering/nestdevs-tasks#85

### Changes description

- Add dependency to pre-commit configuration

---------

Signed-off-by: André Veríssimo <211358+averissimo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averissimo averissimo

Labels
bug Something isn't working core
Projects
None yet
Milestone
No milestone
4 participants
@averissimo @donyunardi @pawelru @cicdguy