Skip to content

Update EG templates #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Update EG templates #169

merged 8 commits into from
Nov 27, 2024

Conversation

edelarua
Copy link
Contributor

Closes #167

@edelarua edelarua added the sme label Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

Unit Tests Summary

  1 files  111 suites   3m 16s ⏱️
243 tests 213 ✅  30 💤 0 ❌
476 runs  235 ✅ 241 💤 0 ❌

Results for commit 315f713.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
pagination_table 💚 $14.49$ $-2.67$ $-9$ $+6$ $0$ $0$
table_aet03 💚 $4.92$ $-3.38$ $-4$ $+1$ $0$ $0$
table_aet04 💚 $12.10$ $-5.84$ $-14$ $+8$ $0$ $0$
table_pkct01 💚 $3.23$ $-1.67$ $-6$ $+2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
pagination_table 💚 $3.64$ $-2.13$ Pagination_works_for_page_types
table_aet03 💚 $4.92$ $-3.38$ AET03_variant_1_is_produced_correctly
table_pkct01 💚 $2.68$ $-1.51$ Specific_PKCT01_features_are_present

Results for commit 6496933

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu self-assigned this Nov 20, 2024
@shajoezhu
Copy link
Contributor

currently following up with the admiral team to update pharmaverseadam data

@manciniedoardo
Copy link

currently following up with the admiral team to update pharmaverseadam data

@shajoezhu Now live in pharmaverseadam/main for you to test again

shajoezhu and others added 4 commits November 26, 2024 10:40
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me! thanks a lot @edelarua

@shajoezhu
Copy link
Contributor

hey @pawelru , we are seeing some new bugs with the dependencies I think https://github.com/insightsengineering/scda.test/actions/runs/12039832790/job/33578386929?pr=169
I was wondering if you could give us some pointers please. thanks!

@shajoezhu shajoezhu enabled auto-merge (squash) November 27, 2024 09:00
@shajoezhu shajoezhu merged commit 3d3b610 into main Nov 27, 2024
29 checks passed
@shajoezhu shajoezhu deleted the 167_adeg_updates@main branch November 27, 2024 09:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@shajoezhu
Copy link
Contributor

dear @manciniedoardo @bundfussr @jeffreyad thank you so much for your support on this. This is now fixed and closed.

thanks so much @edelarua for taking the time to iterate on this! this looks really good now!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upadate table_egt05_qtcat when new admiral data releases
5 participants