-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
229 delayed_choices
as separate funcitons
#232
229 delayed_choices
as separate funcitons
#232
Conversation
delayed_choices
as separate funcitons
I like this approach more as About the exact implementation and other details I haven't reviewed it, but at first glance I'd like the explore the call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good except commented
Co-authored-by: Dawid Kałędkowski <dawid.kaledkowski@gmail.com> Signed-off-by: Aleksander Chlebowski <114988527+chlebowa@users.noreply.github.com>
This reverts commit f1634f5.
@gogonzo Please have a look at my proposed compromise for the modification of |
I have read the CLA Document and I hereby sign the CLA |
added_fun(original_fun(x)) | ||
x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added_fun(original_fun(x)) | |
x | |
added_fun(original_fun(data)) |
Closes #229
Alternative to #231
CHANGES
Added
first_choice
andlast_choice
to extendall_choices
functionality to subsets of available choices.IMPLEMENTATION
all_choices
,first_choice
, andlast_choice
are functions of classdelayed_choices
.delayed_choices
functions will add the appropriate subsetting operation to the$subset
element of theirdelayed_data argument
. Atomic arguments are returned as is.all_choices
is still a special case when checking arguments in some functions (choices
vsmultiple
) so an extra class is added to theall_choices
function to keep track of that.