No way to access album art or thumbnails

[phako]

Looking through the source code, there is no way to access the albumArt or thumbnail on the meta-data of the currently played back item on the renderer

Neither is the raw DIDL-Lite provided, nor is it parsed into the metadata property of MPRIS2.Player

[ljsachs]

Please see https://01.org/dleyna/documentation/dleyna-server/item-objects for a mention of AlbumArtURL

From: phako [mailto:notifications@github.com]
Sent: Friday, August 26, 2016 8:04 AM
To: 01org/dleyna-renderer dleyna-renderer@noreply.github.com
Subject: [01org/dleyna-renderer] No way to access album art or thumbnails (#157)

Looking through the source code, there is no way to access the albumArt or thumbnail on the meta-data of the currently played back item on the renderer

Neither is the raw DIDL-Lite provided, nor is it parsed into the metadata property of MPRIS2.Player

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/157, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJlflF7cTYIUuB47C3QG0-ayvRdwrAPmks5qjwBGgaJpZM4JuKx_.

[phako]

That's the server side, I'm on renderer side. But I'm sorry, I overlooked

str_value = gupnp_didl_lite_object_get_album_art(object);
if (str_value) {
    value = g_variant_new_string(str_value);
    g_variant_builder_add(vb, "{sv}", "mpris:artUrl", value);
}

Now I just have to figure out why it's not appearing

[phako]

The issue is that you unconditionally wrap the metadata supplied by the DLNA renderer in <DIDL-Lite></DIDL-Lite> and that makes GUPnPDIDLLiteParser not find any <item> - GUPnP-AV-CP already provides that wrapper. I have to check whether the meta-data should be supplied with or without the DIDL-Lite framing according to DLNA, but last time I checked with the certification tool (long time ago), it didn't complain about the DMC behavior there.

[phako]

That's what I did now locally - probably not the best way to do this...

diff --git a/libdleyna/renderer/device.c b/libdleyna/renderer/device.c
index 783fb52..8eb7d75 100644
--- a/libdleyna/renderer/device.c
+++ b/libdleyna/renderer/device.c
@@ -1479,13 +1479,19 @@ static void prv_add_track_meta_data(dlr_device_t *device,
                    const gchar *uri,
                    GVariantBuilder *changed_props_vb)
 {
-   gchar *didl = g_strdup_printf("<DIDL-Lite>%s</DIDL-Lite>", metadata);
+   gchar *didl = NULL;
    GUPnPDIDLLiteParser *parser = NULL;
    GVariantBuilder *vb;
    GError *upnp_error = NULL;
    GVariant *val;
    gint error_code;

+   if (g_strstr_len (metadata, 100, "<DIDL-Lite") == NULL) {
+       didl = g_strdup_printf("<DIDL-Lite>%s</DIDL-Lite>", metadata);
+   } else {
+       didl = g_strdup (metadata);
+   }
+
    parser = gupnp_didl_lite_parser_new();

    vb = g_variant_builder_new(G_VARIANT_TYPE("a{sv}"));