[CI] Align inputs #20789
Open
[CI] Align inputs #20789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use underscores for inputs.
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| # Artifacts: | ||
|
|
||
| retention-days: | ||
| retention_days: |
Contributor
There was a problem hiding this comment.
I'm not sure if we should be changing this one. Maybe "pass-through" exception in the naming convention?
Contributor
Author
There was a problem hiding this comment.
To keep the same name as an argument of actions/upload-artifact?
Contributor
Author
There was a problem hiding this comment.
Sure. Should we proceed with something like this or it'd redundant?
Suggested change
| retention_days: | |
| # This name matches the name of the actions/upload-artifact argument | |
| retention-days: |
Contributor
There was a problem hiding this comment.
In all the places? That would be messy :) IMO, close this PR and do nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use underscores for inputs.