Skip to content

[CI] Align inputs #20789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[CI] Align inputs #20789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/sycl-linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ on:

# Artifacts:

retention-days:
retention_days:
Copy link
Contributor

@aelovikov-intel aelovikov-intel Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should be changing this one. Maybe "pass-through" exception in the naming convention?

Copy link
Contributor Author

@KornevNikita KornevNikita Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep the same name as an argument of actions/upload-artifact?

Copy link
Contributor Author

@KornevNikita KornevNikita Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Should we proceed with something like this or it'd redundant?

Suggested change
retention_days:
# This name matches the name of the actions/upload-artifact argument
retention-days:

Copy link
Contributor

@aelovikov-intel aelovikov-intel Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all the places? That would be messy :) IMO, close this PR and do nothing.

description: 'Artifacts retention period'
type: string
default: 3
Expand Down Expand Up @@ -123,7 +123,7 @@ on:
options:
- "default"

retention-days:
retention_days:
type: choice
options:
- 3
Expand Down Expand Up @@ -284,7 +284,7 @@ jobs:
with:
name: ${{ inputs.release_toolchain_artifact }}
path: ${{ steps.artifact_info.outputs.ARCHIVE_NAME }}
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}

- name: Install utilities
if: ${{ !cancelled() && steps.build.conclusion == 'success' }}
Expand All @@ -306,7 +306,7 @@ jobs:
with:
name: ${{ inputs.toolchain_artifact }}
path: ${{ steps.artifact_info.outputs.ARCHIVE_NAME }}
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}


- name: Source OneAPI TBB vars.sh
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/sycl-linux-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ on:
or `run-only`.
type: string
default: 'full'
retention-days:
retention_days:
description: 'E2E/SYCL-CTS binaries artifact retention period.'
type: string
default: 1
Expand Down Expand Up @@ -349,7 +349,7 @@ jobs:
extra_cmake_args: ${{ inputs.extra_cmake_args }}
target_devices: ${{ inputs.target_devices }}
extra_lit_opts: ${{ inputs.extra_lit_opts }}
retention-days: ${{ inputs.retention-days }}
retention_days: ${{ inputs.retention_days }}

- name: Run SYCL CTS Tests
if: inputs.tests_selector == 'cts'
Expand All @@ -365,7 +365,7 @@ jobs:
|| inputs.testing_mode == 'run-only' && 'in-container'
|| '' }}
target_devices: ${{ inputs.target_devices }}
retention-days: ${{ inputs.retention-days }}
retention_days: ${{ inputs.retention_days }}

- name: Run benchmarks
if: inputs.tests_selector == 'benchmarks'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sycl-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
build_configure_extra_args: '--hip --cuda -DSYCL_BUILD_INFO="Nightly ${{ needs.get_date.outputs.date }}"'
build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest

retention-days: 90
retention_days: 90
toolchain_artifact: sycl_linux_default
# We upload the build for people to download/use, override its name and
# prefer widespread gzip compression.
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
uses: ./.github/workflows/sycl-windows-build.yml
if: github.repository == 'intel/llvm'
with:
retention-days: 90
retention_days: 90
# We upload both Linux/Windows build via Github's "Releases"
# functionality, make sure Linux/Windows names follow the same pattern.
toolchain_artifact_filename: sycl_windows.tar.gz
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/sycl-windows-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
required: false

# Artifacts:
retention-days:
retention_days:
description: 'Artifacts retention period'
type: string
default: 3
Expand Down Expand Up @@ -82,7 +82,7 @@ on:
options:
- 'llvm_sycl.tar.gz'
default:
retention-days:
retention_days:
type: choice
options:
- 3
Expand Down Expand Up @@ -202,7 +202,7 @@ jobs:
with:
name: sycl_windows_abi_symbols
path: build/new_sycl_symbols_windows.dump
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}
- name: Install sycl-toolchain
if: ${{ !cancelled() && steps.build.conclusion == 'success' }}
run: |
Expand All @@ -217,7 +217,7 @@ jobs:
with:
name: ${{ inputs.release_toolchain_artifact }}
path: ${{ inputs.toolchain_artifact_filename }}
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}

- name: Install utilities
if: ${{ !cancelled() && steps.build.conclusion == 'success' }}
Expand All @@ -236,7 +236,7 @@ jobs:
with:
name: sycl_windows_default
path: ${{ inputs.toolchain_artifact_filename }}
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}

- name: Setup SYCL toolchain
if: ${{ !cancelled() && steps.build.conclusion == 'success' }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sycl-windows-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
extra_cmake_args: ${{ inputs.extra_cmake_args }}
target_devices: ${{ inputs.target_devices }}
extra_lit_opts: ${{ inputs.extra_lit_opts }}
retention-days: ${{ inputs.artifact_retention_days }}
retention_days: ${{ inputs.artifact_retention_days }}
cxx: ${{ inputs.cxx }}

- name: Run SYCL CTS Tests
Expand All @@ -163,7 +163,7 @@ jobs:
testing_mode: ${{ inputs.testing_mode }}
binaries_artifact: ${{ inputs.binaries_artifact }}
target_devices: ${{ inputs.target_devices }}
retention-days: ${{ inputs.artifact_retention_days }}
retention_days: ${{ inputs.artifact_retention_days }}

- name: Detect hung tests
if: always()
Expand Down
4 changes: 2 additions & 2 deletions devops/actions/run-tests/cts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inputs:
require: false
target_devices:
required: true
retention-days:
retention_days:
required: false

runs:
Expand Down Expand Up @@ -78,7 +78,7 @@ runs:
with:
name: ${{ inputs.binaries_artifact }}
path: sycl_cts_bin.tar.zst
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}

- name: Download SYCL-CTS binaries
if: inputs.testing_mode == 'run-only'
Expand Down
4 changes: 2 additions & 2 deletions devops/actions/run-tests/e2e/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ inputs:
default: all
extra_lit_opts:
required: false
retention-days:
retention_days:
required: false
sycl_compiler:
required: false
Expand Down Expand Up @@ -105,4 +105,4 @@ runs:
with:
name: ${{ inputs.binaries_artifact }}
path: e2e_binaries.tar.zst
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}
4 changes: 2 additions & 2 deletions devops/actions/run-tests/windows/cts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ inputs:
require: false
target_devices:
required: true
retention-days:
retention_days:
required: false

runs:
Expand Down Expand Up @@ -80,7 +80,7 @@ runs:
with:
name: ${{ inputs.binaries_artifact }}
path: sycl_cts_bin.tar.zst
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}

- name: Download SYCL-CTS binaries
if: inputs.testing_mode == 'run-only'
Expand Down
4 changes: 2 additions & 2 deletions devops/actions/run-tests/windows/e2e/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ inputs:
default: all
extra_lit_opts:
required: false
retention-days:
retention_days:
required: false
sycl_compiler:
required: false
Expand Down Expand Up @@ -120,4 +120,4 @@ runs:
with:
name: ${{ inputs.binaries_artifact }}
path: e2e_bin.tar.gz
retention-days: ${{ inputs.retention-days }}
retention-days: ${{ inputs.retention_days }}
Loading