Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly await the Simulator.reset in finish_test.dart #10

Closed
mkorbel1 opened this issue Feb 8, 2023 · 1 comment · Fixed by #42
Closed

Properly await the Simulator.reset in finish_test.dart #10

mkorbel1 opened this issue Feb 8, 2023 · 1 comment · Fixed by #42
Labels
bug Something isn't working

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Feb 8, 2023

The ROHD bug intel/rohd#253 is preventing us from doing an await on Simulator.reset() in finish_test.dart because the simulation doesn't get marked as ended, which the reset will wait for. Once the ROHD bug is fixed, we should adjust this.
@mkorbel1 mkorbel1 added the bug Something isn't working label Feb 8, 2023
@mkorbel1
Copy link
Contributor Author

mkorbel1 commented Jan 2, 2025

Though originally we were waiting for intel/rohd#253, the PR intel/rohd#515 has fixed the behavior enough that we can resolve this.

@mkorbel1 mkorbel1 mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compatibility changes for ROHD v0.6.0 (some) mkorbel1/rohd-cosim
1 participant
@mkorbel1