Skip to content

Should path be an array? #3

Open
@skrat

Description

@skrat

I find it pointless to concat and stringify the path, because if one wants to use it (eg. in a getIn call), it has to be parsed. What's the point of having it as string? Yes I do some pattern matching now, using regular expressions, but even that would be faster and more convenient if path would be an array of actual keys.

Activity

added a commit that references this issue on Jan 17, 2015
772b2c8
pedroteixeira

pedroteixeira commented on Mar 6, 2015

@pedroteixeira
Contributor

Right now, for us, it's more convenient that .toJSON() is compatible to the json patch spec, which adopts json pointer strings rather than arrays: https://tools.ietf.org/html/rfc6902

Will talk about it, perhaps could be an options to the diff function.

NodeGuy

NodeGuy commented on Mar 22, 2017

@NodeGuy
pedroteixeira

pedroteixeira commented on Mar 22, 2017

@pedroteixeira
Contributor

nice! perhaps we could eventually have a single code base, and an API to support both return types

added a commit that references this issue on Jan 11, 2023
ce0b924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @skrat@pedroteixeira@NodeGuy

        Issue actions

          Should path be an array? · Issue #3 · intelie/immutable-js-diff