ut fix

Author: BalaBalaYi

dlrover/python/diagnosis/common/diagnosis_action.py

@@ -260,6 +260,10 @@ def clear(self):
         with self._lock:
             self._actions.clear()
 
+    def len(self):
+        with self._lock:
+            return sum(len(d) for d in self._actions.values())
+
     def next_action(
         self,
         instance=DiagnosisConstant.LOCAL_INSTANCE,

dlrover/python/tests/test_args.py

@@ -13,10 +13,28 @@
 
 import unittest
 
-from dlrover.python.master.args import parse_master_args
+from dlrover.python.master.args import parse_master_args, str2bool
 
 
 class ArgsTest(unittest.TestCase):
+    def test_str2bool(self):
+        self.assertTrue(str2bool("TRUE"))
+        self.assertTrue(str2bool("True"))
+        self.assertTrue(str2bool("true"))
+        self.assertTrue(str2bool("yes"))
+        self.assertTrue(str2bool("t"))
+        self.assertTrue(str2bool("y"))
+        self.assertTrue(str2bool("1"))
+        self.assertTrue(str2bool(True))
+
+        self.assertFalse(str2bool("FALSE"))
+        self.assertFalse(str2bool("False"))
+        self.assertFalse(str2bool("false"))
+        self.assertFalse(str2bool("no"))
+        self.assertFalse(str2bool("n"))
+        self.assertFalse(str2bool("0"))
+        self.assertFalse(str2bool(False))
+
     def test_parse_master_args(self):
         original_args = [
             "--job_name",

dlrover/python/tests/test_diagnosis_manager.py

@@ -15,11 +15,17 @@
 import unittest
 from typing import List
 from unittest import mock
+from unittest.mock import MagicMock
 
+from dlrover.python.common.constants import NodeStatus
 from dlrover.python.diagnosis.common.constants import (
     DiagnosisActionType,
     DiagnosisDataType,
 )
+from dlrover.python.diagnosis.common.diagnosis_action import (
+    DiagnosisAction,
+    NodeAction,
+)
 from dlrover.python.diagnosis.common.diagnosis_data import (
     DiagnosisData,
     TrainingLog,
@@ -38,6 +44,11 @@
     DiagnosisDataManager,
 )
 from dlrover.python.master.diagnosis.diagnosis_manager import DiagnosisManager
+from dlrover.python.master.diagnosis.precheck_operator import (
+    PreCheckOperator,
+    PreCheckResult,
+)
+from dlrover.python.master.node.job_context import get_job_context
 
 
 class DiagnosisManagerTest(unittest.TestCase):
@@ -107,5 +118,35 @@ def test_diagnosis_manager(self):
         self.assertEqual(action.action_type, DiagnosisActionType.NONE)
 
     def test_pre_check(self):
+        job_context = get_job_context()
         mgr = DiagnosisManager()
         mgr.pre_check()
+        self.assertEqual(job_context._action_queue.len(), 0)
+
+        mgr.get_pre_check_operators = MagicMock(return_value=[TestOperator()])
+        mgr.pre_check()
+        self.assertTrue(isinstance(job_context.next_action(1), NodeAction))
+
+
+class TestOperator(PreCheckOperator):
+    @classmethod
+    def get_retry_interval_secs(cls) -> int:
+        return 1
+
+    @classmethod
+    def get_retry_limit_times(cls) -> int:
+        return 1
+
+    def check(self) -> PreCheckResult:
+        return PreCheckResult(1, "test", [1])
+
+    def recover(self):
+        pass
+
+    def get_failed_action(self) -> DiagnosisAction:
+        return NodeAction(
+            node_id=1,
+            node_status=NodeStatus.FAILED,
+            reason="hang",
+            action_type=DiagnosisActionType.MASTER_RELAUNCH_WORKER,
+        )

dlrover/python/tests/test_pre_check_operator.py

@@ -0,0 +1,39 @@
+# Copyright 2025 The DLRover Authors. All rights reserved.
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import unittest
+
+from dlrover.python.diagnosis.common.diagnosis_action import NoAction
+from dlrover.python.master.diagnosis.precheck_operator import (
+    NoPreCheckOperator,
+)
+
+
+class PreCheckOperatorTest(unittest.TestCase):
+    def setUp(self):
+        pass
+
+    def tearDown(self):
+        pass
+
+    def test_no_pre_check_op(self):
+        op = NoPreCheckOperator()
+        self.assertTrue(op.check())
+        op.recover()
+        self.assertEqual(op.get_retry_interval_secs(), 5)
+        self.assertEqual(op.get_retry_limit_times(), 3)
+        self.assertTrue(isinstance(op.get_failed_action(), NoAction))
+
+
+if __name__ == "__main__":
+    unittest.main()