From 1cea264287e94b241d94e89b576fb50a15adb9fe Mon Sep 17 00:00:00 2001
From: raylras <raylras@outlook.com>
Date: Mon, 18 Nov 2024 08:14:45 +0800
Subject: [PATCH 1/7] feat: description index

---
 packages/zenscript/src/module.ts              |  3 +
 .../src/reference/dynamic-provider.ts         | 13 +++--
 .../src/reference/member-provider.ts          | 19 ++++---
 .../src/workspace/description-index.ts        | 55 +++++++++++++++++++
 4 files changed, 75 insertions(+), 15 deletions(-)
 create mode 100644 packages/zenscript/src/workspace/description-index.ts

diff --git a/packages/zenscript/src/module.ts b/packages/zenscript/src/module.ts
index 1c6a0465..bbb5cb14 100644
--- a/packages/zenscript/src/module.ts
+++ b/packages/zenscript/src/module.ts
@@ -17,6 +17,7 @@ import { ZenScriptTypeComputer } from './typing/type-computer'
 import { registerValidationChecks, ZenScriptValidator } from './validation/validator'
 import { ZenScriptBracketManager } from './workspace/bracket-manager'
 import { ZenScriptConfigurationManager } from './workspace/configuration-manager'
+import { ZenScriptDescriptionIndex } from './workspace/description-index'
 import { ZenScriptPackageManager } from './workspace/package-manager'
 import { ZenScriptWorkspaceManager } from './workspace/workspace-manager'
 
@@ -37,6 +38,7 @@ export interface ZenScriptAddedServices {
   workspace: {
     PackageManager: ZenScriptPackageManager
     BracketManager: ZenScriptBracketManager
+    DescriptionIndex: ZenScriptDescriptionIndex
   }
 }
 
@@ -74,6 +76,7 @@ export const ZenScriptModule: Module<ZenScriptServices, PartialLangiumServices &
   workspace: {
     PackageManager: services => new ZenScriptPackageManager(services),
     BracketManager: services => new ZenScriptBracketManager(services),
+    DescriptionIndex: services => new ZenScriptDescriptionIndex(services),
   },
   parser: {
     TokenBuilder: () => new CustomTokenBuilder(),
diff --git a/packages/zenscript/src/reference/dynamic-provider.ts b/packages/zenscript/src/reference/dynamic-provider.ts
index ef9d48eb..613c93f4 100644
--- a/packages/zenscript/src/reference/dynamic-provider.ts
+++ b/packages/zenscript/src/reference/dynamic-provider.ts
@@ -1,7 +1,8 @@
-import type { AstNode, AstNodeDescription, AstNodeDescriptionProvider } from 'langium'
+import type { AstNode, AstNodeDescription } from 'langium'
 import type { ZenScriptAstType } from '../generated/ast'
 import type { ZenScriptServices } from '../module'
 import type { TypeComputer } from '../typing/type-computer'
+import type { DescriptionIndex } from '../workspace/description-index'
 import type { MemberProvider } from './member-provider'
 import { AstUtils, stream } from 'langium'
 import { isCallExpression, isClassDeclaration, isFunctionDeclaration, isOperatorFunctionDeclaration } from '../generated/ast'
@@ -15,12 +16,12 @@ type SourceMap = ZenScriptAstType
 type RuleMap = { [K in keyof SourceMap]?: (source: SourceMap[K]) => AstNodeDescription[] }
 
 export class ZenScriptDynamicProvider implements DynamicProvider {
-  private readonly descriptions: AstNodeDescriptionProvider
+  private readonly descriptionIndex: DescriptionIndex
   private readonly typeComputer: TypeComputer
   private readonly memberProvider: MemberProvider
 
   constructor(services: ZenScriptServices) {
-    this.descriptions = services.workspace.AstNodeDescriptionProvider
+    this.descriptionIndex = services.workspace.DescriptionIndex
     this.typeComputer = services.typing.TypeComputer
     this.memberProvider = services.references.MemberProvider
   }
@@ -37,7 +38,7 @@ export class ZenScriptDynamicProvider implements DynamicProvider {
       // dynamic this
       const classDecl = AstUtils.getContainerOfType(source, isClassDeclaration)
       if (classDecl) {
-        dynamics.push(this.descriptions.createDescription(classDecl, 'this'))
+        dynamics.push(this.descriptionIndex.getThisDescription(classDecl))
       }
 
       // dynamic arguments
@@ -52,7 +53,7 @@ export class ZenScriptDynamicProvider implements DynamicProvider {
               .filter(it => isFunctionDeclaration(it))
               .filter(it => it.prefix === 'static')
               .filter(it => it.parameters.length === 0)
-              .forEach(it => dynamics.push(this.descriptions.createDescription(it, it.name)))
+              .forEach(it => dynamics.push(this.descriptionIndex.getDescription(it)))
           }
         }
       }
@@ -70,7 +71,7 @@ export class ZenScriptDynamicProvider implements DynamicProvider {
         .filter(it => it.parameters.length === 1)
         .find(it => it.op === '.')
       if (operatorDecl) {
-        dynamics.push(this.descriptions.createDescription(operatorDecl.parameters[0], source.target.$refText))
+        dynamics.push(this.descriptionIndex.createDynamicDescription(operatorDecl.parameters[0], source.target.$refText))
       }
 
       return dynamics
diff --git a/packages/zenscript/src/reference/member-provider.ts b/packages/zenscript/src/reference/member-provider.ts
index 1edbcf9f..5fbeb3fe 100644
--- a/packages/zenscript/src/reference/member-provider.ts
+++ b/packages/zenscript/src/reference/member-provider.ts
@@ -1,13 +1,14 @@
-import type { AstNode, AstNodeDescription, AstNodeDescriptionProvider } from 'langium'
+import type { AstNode, AstNodeDescription } from 'langium'
 import type { ZenScriptAstType } from '../generated/ast'
 import type { ZenScriptServices } from '../module'
 import type { TypeComputer } from '../typing/type-computer'
+import type { DescriptionIndex } from '../workspace/description-index'
 import type { ZenScriptSyntheticAstType } from './synthetic'
 import { stream } from 'langium'
 import { isClassDeclaration, isVariableDeclaration } from '../generated/ast'
 import { ClassType, isAnyType, isClassType, isFunctionType, type Type, type ZenScriptType } from '../typing/type-description'
 import { getClassChain, isStatic } from '../utils/ast'
-import { createSyntheticAstNodeDescription, isSyntheticAstNode } from './synthetic'
+import { isSyntheticAstNode } from './synthetic'
 
 export interface MemberProvider {
   getMembers: (source: AstNode | Type | undefined) => AstNodeDescription[]
@@ -17,11 +18,11 @@ type SourceMap = ZenScriptAstType & ZenScriptType & ZenScriptSyntheticAstType
 type RuleMap = { [K in keyof SourceMap]?: (source: SourceMap[K]) => AstNodeDescription[] }
 
 export class ZenScriptMemberProvider implements MemberProvider {
-  private readonly descriptions: AstNodeDescriptionProvider
+  private readonly descriptionIndex: DescriptionIndex
   private readonly typeComputer: TypeComputer
 
   constructor(services: ZenScriptServices) {
-    this.descriptions = services.workspace.AstNodeDescriptionProvider
+    this.descriptionIndex = services.workspace.DescriptionIndex
     this.typeComputer = services.typing.TypeComputer
   }
 
@@ -35,10 +36,10 @@ export class ZenScriptMemberProvider implements MemberProvider {
       const declarations = stream(source.children.values())
         .filter(it => it.isDataNode())
         .flatMap(it => it.data)
-        .map(it => this.descriptions.createDescription(it, undefined))
+        .map(it => this.descriptionIndex.getDescription(it))
       const packages = stream(source.children.values())
         .filter(it => it.isInternalNode())
-        .map(it => createSyntheticAstNodeDescription('SyntheticHierarchyNode', it.name, it))
+        .map(it => this.descriptionIndex.getPackageDescription(it))
       return stream(declarations, packages).toArray()
     },
 
@@ -49,7 +50,7 @@ export class ZenScriptMemberProvider implements MemberProvider {
       source.statements.filter(it => isVariableDeclaration(it))
         .filter(it => it.prefix === 'static')
         .forEach(it => members.push(it))
-      return members.map(it => this.descriptions.createDescription(it, undefined))
+      return members.map(it => this.descriptionIndex.getDescription(it))
     },
 
     ImportDeclaration: (source) => {
@@ -60,7 +61,7 @@ export class ZenScriptMemberProvider implements MemberProvider {
       return getClassChain(source)
         .flatMap(it => it.members)
         .filter(it => isStatic(it))
-        .map(it => this.descriptions.createDescription(it, undefined))
+        .map(it => this.descriptionIndex.getDescription(it))
     },
 
     VariableDeclaration: (source) => {
@@ -162,7 +163,7 @@ export class ZenScriptMemberProvider implements MemberProvider {
       return getClassChain(source.declaration)
         .flatMap(it => it.members)
         .filter(it => !isStatic(it))
-        .map(it => this.descriptions.createDescription(it, undefined))
+        .map(it => this.descriptionIndex.getDescription(it))
     },
   }
 }
diff --git a/packages/zenscript/src/workspace/description-index.ts b/packages/zenscript/src/workspace/description-index.ts
new file mode 100644
index 00000000..ea43c499
--- /dev/null
+++ b/packages/zenscript/src/workspace/description-index.ts
@@ -0,0 +1,55 @@
+import type { HierarchyNode } from '@intellizen/shared'
+import type { AstNode, AstNodeDescription, AstNodeDescriptionProvider } from 'langium'
+import type { ClassDeclaration } from '../generated/ast'
+import type { ZenScriptServices } from '../module'
+import { createSyntheticAstNodeDescription } from '../reference/synthetic'
+
+export interface DescriptionIndex {
+  getDescription: (astNode: AstNode) => AstNodeDescription
+  getPackageDescription: (pkgNode: HierarchyNode<AstNode>) => AstNodeDescription
+  getThisDescription: (classDecl: ClassDeclaration) => AstNodeDescription
+  createDynamicDescription: (astNode: AstNode, name: string) => AstNodeDescription
+}
+
+export class ZenScriptDescriptionIndex implements DescriptionIndex {
+  private readonly descriptions: AstNodeDescriptionProvider
+
+  private readonly astDescriptions: WeakMap<AstNode, AstNodeDescription>
+  private readonly pkgDescriptions: WeakMap<HierarchyNode<AstNode>, AstNodeDescription>
+  private readonly thisDescriptions: WeakMap<ClassDeclaration, AstNodeDescription>
+
+  constructor(services: ZenScriptServices) {
+    this.descriptions = services.workspace.AstNodeDescriptionProvider
+    this.astDescriptions = new WeakMap()
+    this.pkgDescriptions = new WeakMap()
+    this.thisDescriptions = new WeakMap()
+  }
+
+  getDescription(astNode: AstNode): AstNodeDescription {
+    if (!this.astDescriptions.has(astNode)) {
+      this.astDescriptions.set(astNode, this.descriptions.createDescription(astNode, undefined))
+    }
+    return this.astDescriptions.get(astNode)!
+  }
+
+  getPackageDescription(pkgNode: HierarchyNode<AstNode>): AstNodeDescription {
+    if (pkgNode.isDataNode()) {
+      throw new Error(`Expected a package node, but received a data node: ${pkgNode}`)
+    }
+    if (!this.pkgDescriptions.has(pkgNode)) {
+      this.pkgDescriptions.set(pkgNode, createSyntheticAstNodeDescription('SyntheticHierarchyNode', pkgNode.name, pkgNode))
+    }
+    return this.pkgDescriptions.get(pkgNode)!
+  }
+
+  getThisDescription(classDecl: ClassDeclaration): AstNodeDescription {
+    if (!this.thisDescriptions.has(classDecl)) {
+      this.thisDescriptions.set(classDecl, this.descriptions.createDescription(classDecl, 'this'))
+    }
+    return this.thisDescriptions.get(classDecl)!
+  }
+
+  createDynamicDescription(astNode: AstNode, name: string): AstNodeDescription {
+    return this.descriptions.createDescription(astNode, name)
+  }
+}

From 52960a8e9d55979b99d4c430a98431d793cf511c Mon Sep 17 00:00:00 2001
From: raylras <raylras@outlook.com>
Date: Mon, 18 Nov 2024 08:59:12 +0800
Subject: [PATCH 2/7] set ast descriptions

---
 .../src/reference/scope-computation.ts         | 18 +++++++++++++++++-
 .../src/workspace/description-index.ts         |  6 +++---
 2 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/packages/zenscript/src/reference/scope-computation.ts b/packages/zenscript/src/reference/scope-computation.ts
index 880a155c..0ed2e94e 100644
--- a/packages/zenscript/src/reference/scope-computation.ts
+++ b/packages/zenscript/src/reference/scope-computation.ts
@@ -1,12 +1,16 @@
-import type { AstNode, AstNodeDescription, LangiumDocument } from 'langium'
+import type { AstNode, AstNodeDescription, LangiumDocument, PrecomputedScopes } from 'langium'
 import type { Script } from '../generated/ast'
 import type { ZenScriptServices } from '../module'
+import type { ZenScriptDescriptionIndex } from '../workspace/description-index'
 import { DefaultScopeComputation } from 'langium'
 import { isGlobal } from '../utils/ast'
 
 export class ZenScriptScopeComputation extends DefaultScopeComputation {
+  private readonly descriptionIndex: ZenScriptDescriptionIndex
+
   constructor(services: ZenScriptServices) {
     super(services)
+    this.descriptionIndex = services.workspace.DescriptionIndex
   }
 
   protected override exportNode(node: AstNode, exports: AstNodeDescription[], document: LangiumDocument<Script>): void {
@@ -14,4 +18,16 @@ export class ZenScriptScopeComputation extends DefaultScopeComputation {
       exports.push(this.descriptions.createDescription(node, undefined, document))
     }
   }
+
+  protected override processNode(node: AstNode, document: LangiumDocument, scopes: PrecomputedScopes): void {
+    const container = node.$container
+    if (container) {
+      const name = this.nameProvider.getName(node)
+      if (name) {
+        const description = this.descriptions.createDescription(node, name, document)
+        this.descriptionIndex.astDescriptions.set(node, description)
+        scopes.add(container, description)
+      }
+    }
+  }
 }
diff --git a/packages/zenscript/src/workspace/description-index.ts b/packages/zenscript/src/workspace/description-index.ts
index ea43c499..41f846a9 100644
--- a/packages/zenscript/src/workspace/description-index.ts
+++ b/packages/zenscript/src/workspace/description-index.ts
@@ -14,9 +14,9 @@ export interface DescriptionIndex {
 export class ZenScriptDescriptionIndex implements DescriptionIndex {
   private readonly descriptions: AstNodeDescriptionProvider
 
-  private readonly astDescriptions: WeakMap<AstNode, AstNodeDescription>
-  private readonly pkgDescriptions: WeakMap<HierarchyNode<AstNode>, AstNodeDescription>
-  private readonly thisDescriptions: WeakMap<ClassDeclaration, AstNodeDescription>
+  readonly astDescriptions: WeakMap<AstNode, AstNodeDescription>
+  readonly pkgDescriptions: WeakMap<HierarchyNode<AstNode>, AstNodeDescription>
+  readonly thisDescriptions: WeakMap<ClassDeclaration, AstNodeDescription>
 
   constructor(services: ZenScriptServices) {
     this.descriptions = services.workspace.AstNodeDescriptionProvider

From 617de83e68c81456dd84ebbfe815c8aed9a73ede Mon Sep 17 00:00:00 2001
From: WarmthDawn <warmth06@sina.com>
Date: Mon, 18 Nov 2024 12:09:45 +0800
Subject: [PATCH 3/7] perf: imporve performance for dynamic provider

---
 .../zenscript/src/reference/scope-provider.ts | 27 ++++++++++++++-----
 .../src/workspace/description-index.ts        | 20 ++++++++++++++
 2 files changed, 41 insertions(+), 6 deletions(-)

diff --git a/packages/zenscript/src/reference/scope-provider.ts b/packages/zenscript/src/reference/scope-provider.ts
index 9ab62cc3..915c73c1 100644
--- a/packages/zenscript/src/reference/scope-provider.ts
+++ b/packages/zenscript/src/reference/scope-provider.ts
@@ -1,6 +1,7 @@
 import type { AstNode, AstNodeDescription, ReferenceInfo, Scope } from 'langium'
 import type { ZenScriptAstType } from '../generated/ast'
 import type { ZenScriptServices } from '../module'
+import type { ZenScriptDescriptionIndex } from '../workspace/description-index'
 import type { PackageManager } from '../workspace/package-manager'
 import type { DynamicProvider } from './dynamic-provider'
 import type { MemberProvider } from './member-provider'
@@ -18,12 +19,14 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
   private readonly packageManager: PackageManager
   private readonly memberProvider: MemberProvider
   private readonly dynamicProvider: DynamicProvider
+  private readonly descriptionIndex: ZenScriptDescriptionIndex
 
   constructor(services: ZenScriptServices) {
     super(services)
     this.packageManager = services.workspace.PackageManager
     this.memberProvider = services.references.MemberProvider
     this.dynamicProvider = services.references.DynamicProvider
+    this.descriptionIndex = services.workspace.DescriptionIndex
   }
 
   override getScope(context: ReferenceInfo): Scope {
@@ -68,6 +71,22 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
     return this.createScope(classes, outside)
   }
 
+  private importAlias(importDesc: AstNodeDescription) {
+    const importDecl = importDesc.node as ImportDeclaration
+
+    const targetRef = importDecl.path.at(-1)
+    // call ref to ensure the reference is resolved
+    if (!targetRef?.ref) {
+      return importDesc
+    }
+
+    const targetDesc = importDecl.path.at(-1)?.$nodeDescription ?? importDesc
+    if (!importDecl.alias) {
+      return targetDesc
+    }
+    return this.descriptionIndex.createAliasDescription(targetDesc || importDesc, importDecl.alias)
+  }
+
   private readonly rules: RuleMap = {
     ImportDeclaration: (source) => {
       const path = getPathAsString(source.container, source.index)
@@ -100,9 +119,7 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
           case TypeParameter:
             return
           case ImportDeclaration: {
-            const importDecl = desc.node as ImportDeclaration
-            const ref = importDecl.path.at(-1)?.ref ?? importDecl
-            return this.descriptions.createDescription(ref, this.nameProvider.getName(importDecl))
+            return this.importAlias(desc)
           }
           default:
             return desc
@@ -126,9 +143,7 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
             case ClassDeclaration:
               return desc
             case ImportDeclaration: {
-              const importDecl = desc.node as ImportDeclaration
-              const ref = importDecl.path.at(-1)?.ref ?? importDecl
-              return this.descriptions.createDescription(ref, this.nameProvider.getName(importDecl))
+              return this.importAlias(desc)
             }
           }
         }
diff --git a/packages/zenscript/src/workspace/description-index.ts b/packages/zenscript/src/workspace/description-index.ts
index 41f846a9..868c0bea 100644
--- a/packages/zenscript/src/workspace/description-index.ts
+++ b/packages/zenscript/src/workspace/description-index.ts
@@ -9,6 +9,8 @@ export interface DescriptionIndex {
   getPackageDescription: (pkgNode: HierarchyNode<AstNode>) => AstNodeDescription
   getThisDescription: (classDecl: ClassDeclaration) => AstNodeDescription
   createDynamicDescription: (astNode: AstNode, name: string) => AstNodeDescription
+  // create ast node description with alias name, reusing some info, for better performance
+  createAliasDescription: (origin: AstNodeDescription, newName: string) => AstNodeDescription
 }
 
 export class ZenScriptDescriptionIndex implements DescriptionIndex {
@@ -52,4 +54,22 @@ export class ZenScriptDescriptionIndex implements DescriptionIndex {
   createDynamicDescription(astNode: AstNode, name: string): AstNodeDescription {
     return this.descriptions.createDescription(astNode, name)
   }
+
+  createAliasDescription(origin: AstNodeDescription, newName: string): AstNodeDescription {
+    if (newName === origin.name) {
+      return origin
+    }
+    const { node, selectionSegment, type, documentUri, path } = origin
+    return {
+      node,
+      name: newName,
+      get nameSegment() {
+        return origin.nameSegment
+      },
+      selectionSegment,
+      type,
+      documentUri,
+      path,
+    }
+  }
 }

From f5c8a931227ed725c8467d40d01a18b57dec695b Mon Sep 17 00:00:00 2001
From: raylras <raylras@outlook.com>
Date: Mon, 18 Nov 2024 12:23:03 +0800
Subject: [PATCH 4/7] use index

---
 packages/zenscript/src/reference/scope-provider.ts | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/packages/zenscript/src/reference/scope-provider.ts b/packages/zenscript/src/reference/scope-provider.ts
index 915c73c1..8723e661 100644
--- a/packages/zenscript/src/reference/scope-provider.ts
+++ b/packages/zenscript/src/reference/scope-provider.ts
@@ -10,7 +10,6 @@ import { AstUtils, DefaultScopeProvider, EMPTY_SCOPE, stream } from 'langium'
 import { ClassDeclaration, ImportDeclaration, isClassDeclaration, TypeParameter } from '../generated/ast'
 import { getPathAsString } from '../utils/ast'
 import { generateStream } from '../utils/stream'
-import { createSyntheticAstNodeDescription } from './synthetic'
 
 type SourceMap = ZenScriptAstType
 type RuleMap = { [K in keyof SourceMap]?: (source: ReferenceInfo & { container: SourceMap[K] }) => Scope }
@@ -58,7 +57,7 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
   private packageScope(outside?: Scope) {
     const packages = stream(this.packageManager.root.children.values())
       .filter(it => it.isInternalNode())
-      .map(it => createSyntheticAstNodeDescription('SyntheticHierarchyNode', it.name, it))
+      .map(it => this.descriptionIndex.getPackageDescription(it))
     return this.createScope(packages, outside)
   }
 
@@ -67,7 +66,7 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
       .filter(it => it.isDataNode())
       .flatMap(it => it.data)
       .filter(isClassDeclaration)
-      .map(it => this.descriptions.createDescription(it, it.name))
+      .map(it => this.descriptionIndex.getDescription(it))
     return this.createScope(classes, outside)
   }
 
@@ -99,10 +98,10 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
       const elements: AstNodeDescription[] = []
       for (const sibling of siblings) {
         if (sibling.isDataNode()) {
-          sibling.data.forEach(it => elements.push(this.descriptions.createDescription(it, sibling.name)))
+          sibling.data.forEach(it => elements.push(this.descriptionIndex.getDescription(it)))
         }
         else {
-          elements.push(createSyntheticAstNodeDescription('SyntheticHierarchyNode', sibling.name, sibling))
+          elements.push(this.descriptionIndex.getPackageDescription(sibling))
         }
       }
       return this.createScope(elements)

From 411ac042794a51037dc0f16b947c388c1a0d98e3 Mon Sep 17 00:00:00 2001
From: raylras <raylras@outlook.com>
Date: Mon, 18 Nov 2024 12:31:19 +0800
Subject: [PATCH 5/7] minor improve

---
 .../src/workspace/description-index.ts        | 21 +++----------------
 1 file changed, 3 insertions(+), 18 deletions(-)

diff --git a/packages/zenscript/src/workspace/description-index.ts b/packages/zenscript/src/workspace/description-index.ts
index 868c0bea..38761de5 100644
--- a/packages/zenscript/src/workspace/description-index.ts
+++ b/packages/zenscript/src/workspace/description-index.ts
@@ -9,8 +9,7 @@ export interface DescriptionIndex {
   getPackageDescription: (pkgNode: HierarchyNode<AstNode>) => AstNodeDescription
   getThisDescription: (classDecl: ClassDeclaration) => AstNodeDescription
   createDynamicDescription: (astNode: AstNode, name: string) => AstNodeDescription
-  // create ast node description with alias name, reusing some info, for better performance
-  createAliasDescription: (origin: AstNodeDescription, newName: string) => AstNodeDescription
+  createAliasDescription: (origin: AstNodeDescription, alias: string) => AstNodeDescription
 }
 
 export class ZenScriptDescriptionIndex implements DescriptionIndex {
@@ -55,21 +54,7 @@ export class ZenScriptDescriptionIndex implements DescriptionIndex {
     return this.descriptions.createDescription(astNode, name)
   }
 
-  createAliasDescription(origin: AstNodeDescription, newName: string): AstNodeDescription {
-    if (newName === origin.name) {
-      return origin
-    }
-    const { node, selectionSegment, type, documentUri, path } = origin
-    return {
-      node,
-      name: newName,
-      get nameSegment() {
-        return origin.nameSegment
-      },
-      selectionSegment,
-      type,
-      documentUri,
-      path,
-    }
+  createAliasDescription(origin: AstNodeDescription, alias: string): AstNodeDescription {
+    return Object.assign({ name: alias }, origin)
   }
 }

From acdeb6b6f9379f62143533c74ee4aa5b649f976e Mon Sep 17 00:00:00 2001
From: raylras <raylras@outlook.com>
Date: Mon, 18 Nov 2024 12:58:04 +0800
Subject: [PATCH 6/7] refactor to `createImportedDescription`

---
 .../zenscript/src/reference/scope-provider.ts | 20 ++-----------------
 .../src/workspace/description-index.ts        |  9 +++++----
 2 files changed, 7 insertions(+), 22 deletions(-)

diff --git a/packages/zenscript/src/reference/scope-provider.ts b/packages/zenscript/src/reference/scope-provider.ts
index 8723e661..fc7d445a 100644
--- a/packages/zenscript/src/reference/scope-provider.ts
+++ b/packages/zenscript/src/reference/scope-provider.ts
@@ -70,22 +70,6 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
     return this.createScope(classes, outside)
   }
 
-  private importAlias(importDesc: AstNodeDescription) {
-    const importDecl = importDesc.node as ImportDeclaration
-
-    const targetRef = importDecl.path.at(-1)
-    // call ref to ensure the reference is resolved
-    if (!targetRef?.ref) {
-      return importDesc
-    }
-
-    const targetDesc = importDecl.path.at(-1)?.$nodeDescription ?? importDesc
-    if (!importDecl.alias) {
-      return targetDesc
-    }
-    return this.descriptionIndex.createAliasDescription(targetDesc || importDesc, importDecl.alias)
-  }
-
   private readonly rules: RuleMap = {
     ImportDeclaration: (source) => {
       const path = getPathAsString(source.container, source.index)
@@ -118,7 +102,7 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
           case TypeParameter:
             return
           case ImportDeclaration: {
-            return this.importAlias(desc)
+            return this.descriptionIndex.createImportedDescription(desc.node as ImportDeclaration)
           }
           default:
             return desc
@@ -142,7 +126,7 @@ export class ZenScriptScopeProvider extends DefaultScopeProvider {
             case ClassDeclaration:
               return desc
             case ImportDeclaration: {
-              return this.importAlias(desc)
+              return this.descriptionIndex.createImportedDescription(desc.node as ImportDeclaration)
             }
           }
         }
diff --git a/packages/zenscript/src/workspace/description-index.ts b/packages/zenscript/src/workspace/description-index.ts
index 38761de5..d0617260 100644
--- a/packages/zenscript/src/workspace/description-index.ts
+++ b/packages/zenscript/src/workspace/description-index.ts
@@ -1,6 +1,6 @@
 import type { HierarchyNode } from '@intellizen/shared'
 import type { AstNode, AstNodeDescription, AstNodeDescriptionProvider } from 'langium'
-import type { ClassDeclaration } from '../generated/ast'
+import type { ClassDeclaration, ImportDeclaration } from '../generated/ast'
 import type { ZenScriptServices } from '../module'
 import { createSyntheticAstNodeDescription } from '../reference/synthetic'
 
@@ -9,7 +9,7 @@ export interface DescriptionIndex {
   getPackageDescription: (pkgNode: HierarchyNode<AstNode>) => AstNodeDescription
   getThisDescription: (classDecl: ClassDeclaration) => AstNodeDescription
   createDynamicDescription: (astNode: AstNode, name: string) => AstNodeDescription
-  createAliasDescription: (origin: AstNodeDescription, alias: string) => AstNodeDescription
+  createImportedDescription: (importDecl: ImportDeclaration) => AstNodeDescription
 }
 
 export class ZenScriptDescriptionIndex implements DescriptionIndex {
@@ -54,7 +54,8 @@ export class ZenScriptDescriptionIndex implements DescriptionIndex {
     return this.descriptions.createDescription(astNode, name)
   }
 
-  createAliasDescription(origin: AstNodeDescription, alias: string): AstNodeDescription {
-    return Object.assign({ name: alias }, origin)
+  createImportedDescription(importDecl: ImportDeclaration): AstNodeDescription {
+    const ref = importDecl.path.at(-1)?.ref ?? importDecl
+    return this.descriptions.createDescription(ref, undefined)
   }
 }

From 3c9fd303075f45263dbc3f3b4f337e506e22b67d Mon Sep 17 00:00:00 2001
From: raylras <raylras@outlook.com>
Date: Mon, 18 Nov 2024 13:02:18 +0800
Subject: [PATCH 7/7] fix alias

---
 packages/zenscript/src/workspace/description-index.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/zenscript/src/workspace/description-index.ts b/packages/zenscript/src/workspace/description-index.ts
index d0617260..230125f7 100644
--- a/packages/zenscript/src/workspace/description-index.ts
+++ b/packages/zenscript/src/workspace/description-index.ts
@@ -1,5 +1,5 @@
 import type { HierarchyNode } from '@intellizen/shared'
-import type { AstNode, AstNodeDescription, AstNodeDescriptionProvider } from 'langium'
+import type { AstNode, AstNodeDescription, AstNodeDescriptionProvider, NameProvider } from 'langium'
 import type { ClassDeclaration, ImportDeclaration } from '../generated/ast'
 import type { ZenScriptServices } from '../module'
 import { createSyntheticAstNodeDescription } from '../reference/synthetic'
@@ -14,6 +14,7 @@ export interface DescriptionIndex {
 
 export class ZenScriptDescriptionIndex implements DescriptionIndex {
   private readonly descriptions: AstNodeDescriptionProvider
+  private readonly nameProvider: NameProvider
 
   readonly astDescriptions: WeakMap<AstNode, AstNodeDescription>
   readonly pkgDescriptions: WeakMap<HierarchyNode<AstNode>, AstNodeDescription>
@@ -21,6 +22,7 @@ export class ZenScriptDescriptionIndex implements DescriptionIndex {
 
   constructor(services: ZenScriptServices) {
     this.descriptions = services.workspace.AstNodeDescriptionProvider
+    this.nameProvider = services.references.NameProvider
     this.astDescriptions = new WeakMap()
     this.pkgDescriptions = new WeakMap()
     this.thisDescriptions = new WeakMap()
@@ -56,6 +58,6 @@ export class ZenScriptDescriptionIndex implements DescriptionIndex {
 
   createImportedDescription(importDecl: ImportDeclaration): AstNodeDescription {
     const ref = importDecl.path.at(-1)?.ref ?? importDecl
-    return this.descriptions.createDescription(ref, undefined)
+    return this.descriptions.createDescription(ref, this.nameProvider.getName(importDecl))
   }
 }