Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committee OpenAPI 3 locked to version 3.0.x #303

Closed
hedselu opened this issue Apr 8, 2021 · 8 comments
Closed

Committee OpenAPI 3 locked to version 3.0.x #303

hedselu opened this issue Apr 8, 2021 · 8 comments

Comments

@hedselu
Copy link

hedselu commented Apr 8, 2021

Hi!

First of all, thanks for great gem. I just found a problem when I upgrade OpenAPI version in document to 3.1.0.
The current implementation has locked version to 3.0.x, and fails finding paths for this document.

Current behaviour:

  • runs HyperSchema driver for version OpenAPI version 3.x.x

Expected behaviour:

  • runs OpenAPI3 driver for version OpenAPI 3.x.x

Related committee file for this issue: https://github.com/interagent/committee/blob/v4.3.0/lib/committee/drivers.rb#L52
Latest version of OpenAPI changelog: https://github.com/OAI/OpenAPI-Specification/releases

@ota42y
Copy link
Member

ota42y commented Apr 8, 2021

Thank you for reporting!
However, committee doen't support OpenAPI 3.1.0 yet.
(I have not been able to verify that it works properly)

So we can't load OpenAPI 3.1.0 now sorry

@hedselu
Copy link
Author

hedselu commented Apr 8, 2021

@ota42y understandable, thank you for answering!

Let me know if I should try verifying support for 3.1.x or someone else might take care of this. Of course I'd be happy to contribute.

@ota42y
Copy link
Member

ota42y commented Apr 8, 2021

I haven't check the OpenAPI 3.1.0 specification yet, so I haven't decided how much modification is needed ... 🙇

@hedselu
Copy link
Author

hedselu commented Apr 8, 2021

@ota42y no problem, thanks for response! 🙏

@ahx
Copy link

ahx commented Apr 3, 2023

One of the main differences with 3.1 and committee that I have noticed is the type field in JSON Schema. In 3.0 (and legacy JSON Schema version) it only accepts a string like type: integer, but in 3.1 (and at least JSON Schema draft-7) it support lists as well like type: [integer, string] or even type: [integer, null] (which replaces nullable).

https://github.com/davishmcclurg/json_schemer supports draft-7.

@chrishough
Copy link

@ahx that type nullable is really nice

@geemus
Copy link
Member

geemus commented Nov 6, 2024

I've been working on compiling notes on changes that will be needed. I think also that we can probably add a little at a time (ie we don't have to wait to support all of 3.1 before we support parts). It may still take a little while though and I'd certainly welcome help from others to keep moving it forward.

@geemus
Copy link
Member

geemus commented Nov 8, 2024

Hey, I agree that 3.1 would be great to continue working toward. That said, I think this is at least mostly a duplicate of #352. So I'm going to close this in favor of consolidating discussion in one place. I'd welcome folks to continue adding their questions and thoughts over there.

@geemus geemus closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants