You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using an HTTP proxy for all the outbound requests.
If the proxy cannot establish the HTTP tunnel to api.intercom.com, we expect an exception that is easy to debug.
Actual behavior
undefined is thrown when an error that is not parsable is encountered; in our case: when the proxy server cannot reach intercom API.
The Client.checkOnErrorInResponse() returns undefined when the error does not have the intercom API format.
In this case, I think that setting the response body as an error message (instead of undefined) would be a nice improvement.
Steps to reproduce
set baseURL to a local HTTP server that responds with a >=400 status code:
The text was updated successfully, but these errors were encountered:
BogdanCln
changed the title
Do not throw 'null' when the response body does not match the intercom API format
Do not throw undefined when the response body does not match the intercom API format
Oct 3, 2023
Version info
Expected behavior
We are using an HTTP proxy for all the outbound requests.
If the proxy cannot establish the HTTP tunnel to api.intercom.com, we expect an exception that is easy to debug.
Actual behavior
undefined
is thrown when an error that is not parsable is encountered; in our case: when the proxy server cannot reach intercom API.The Client.checkOnErrorInResponse() returns undefined when the error does not have the intercom API format.
In this case, I think that setting the response body as an error message (instead of undefined) would be a nice improvement.
Steps to reproduce
The text was updated successfully, but these errors were encountered: