-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta issue for upgrading to latest version of packages #374
Comments
Fixed update to async3 - two breaking changes in queue.drain and "until" see https://github.com/caolan/async/blob/master/CHANGELOG.md |
Sharp 0.31.3 works as long as node is at least v14 (Macs are v18 at this point) |
Looks like sharp 0.31.3 is a problem, going back to 0.31.2 and not sure of any reason to push this - maybe fixed in later version. |
The code in Hashstore.js is based on level 5, there are major API level differences with level 8 |
multihashes 0.4.x -> 4.x significant changes which may or may not break things - esp using Uint8 instead of Buffer. It seems to work. It is used in one line only, in MirrorFS.js
This appears to work, so upgrading, but may role back if issues. |
Note that readable-stream was upgraded from v3.4.0 to v4.3.0 which has breaking changes as it matches that in node, but because require('stream').Transform is running in node, readable-stream isnt actually used. If it run into problems maybe need to revert. |
These are known problems with current versions as of 2022-1-17 (includes all comments till that date)
[ ] @internetarchive/bookreader v5 seems to be substantially different and fails with a lot of React errors
[ ] sharp 0.31.3 had problems loading - I've seen these elsewhere and may be a node version issue but 0.31.2 is fine
[ ] level 8.x has major changes from 5.x and its unclear the value of upgrading
[ ] Using current @internetarchive/dweb-archive-dist but that will have dependencies
[ ] Using current @internetarchive/dweb-archivecontroller but that will have dependencies
[ ] Using current @internetarchive/dweb-transports but that will have dependencies
The text was updated successfully, but these errors were encountered: