Skip to content

Commit 8402b00

Browse files
authored
Merge pull request #423 from internetee/disclose-registrant-org-phone
Add special phone disclosure handling for organizational registrants
2 parents df29083 + ab4a270 commit 8402b00

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

app/presenters/registrant_presenter.rb

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ def email
99
end
1010

1111
def phone
12-
# publishable_attribute('phone')
13-
disclose_data_priv_registrant('phone')
12+
registrant_is_org? ? disclose_registrant_org_phone : disclose_data_priv_registrant('phone')
1413
end
1514

1615
def last_update
@@ -27,6 +26,18 @@ def disclose_attr(attr)
2726
end
2827
end
2928

29+
def disclose_registrant_org_phone
30+
phone_disclosed_and_captcha_solved = contact.attribute_disclosed?('phone') && captcha_solved?
31+
32+
if phone_disclosed_and_captcha_solved || whitelisted_user? || registrant_publishable?
33+
contact.send('phone')
34+
elsif !contact.attribute_disclosed?('phone')
35+
undisclosable_mask
36+
else
37+
disclosable_mask
38+
end
39+
end
40+
3041
def disclose_data_priv_registrant(attr)
3142
return contact.send(attr.to_sym) if whitelisted_user?
3243
return undisclosable_mask unless contact.attribute_disclosed?(attr)

test/integration/whois_records/json_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_hide_sensitive_data_of_legal_entity_when_captcha_is_unsolved
125125
response_json = JSON.parse(response.body, symbolize_names: true)
126126

127127
assert_equal 'Not Disclosed - Visit www.internet.ee for web-based WHOIS', response_json[:email]
128-
assert_equal 'Not Disclosed', response_json[:phone]
128+
assert_equal 'Not Disclosed - Visit www.internet.ee for web-based WHOIS', response_json[:phone]
129129

130130
expected_admin_contacts = [
131131
{ name: 'Not Disclosed - Visit www.internet.ee for web-based WHOIS',
@@ -233,7 +233,7 @@ def test_hide_sensitive_data_of_legal_entity_when_ip_is_not_in_whitelist
233233
response_json = JSON.parse(response.body, symbolize_names: true)
234234

235235
assert_equal 'Not Disclosed - Visit www.internet.ee for web-based WHOIS', response_json[:email]
236-
assert_equal 'Not Disclosed', response_json[:phone]
236+
assert_equal 'Not Disclosed - Visit www.internet.ee for web-based WHOIS', response_json[:phone]
237237
assert_equal 'Not Disclosed - Visit www.internet.ee for web-based WHOIS',
238238
response_json[:registrant_changed]
239239

0 commit comments

Comments
 (0)