Skip to content

Commit 391ec55

Browse files
authored
Fix/flaky test (#402)
* fix: flaky test using fakeTimers * fix: restore terminal logs
1 parent 31687e3 commit 391ec55

File tree

2 files changed

+25
-4
lines changed

2 files changed

+25
-4
lines changed

src/utils/logger.utils.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,3 +49,19 @@ export const webdavLogger = winston.createLogger({
4949
}),
5050
],
5151
});
52+
53+
if (process.env.NODE_ENV !== 'production') {
54+
webdavLogger.add(
55+
new winston.transports.Console({
56+
format: winston.format.simple(),
57+
}),
58+
);
59+
}
60+
61+
if (process.env.NODE_ENV !== 'production') {
62+
logger.add(
63+
new winston.transports.Console({
64+
format: winston.format.simple(),
65+
}),
66+
);
67+
}

test/webdav/services/webdav-folder.service.test.ts

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ describe('WebDavFolderService', () => {
130130

131131
describe('createFolder', () => {
132132
it('it should wait 500ms for backend propagation when folder is created', async () => {
133+
vi.useFakeTimers();
134+
133135
const folderResponse = newCreateFolderResponse({
134136
plainName: 'test-folder',
135137
uuid: 'test-uuid',
@@ -140,20 +142,23 @@ describe('WebDavFolderService', () => {
140142
{ cancel: () => {} },
141143
]);
142144

143-
const startTime = Date.now();
144-
const result = await sut.createFolder({
145+
const createPromise = sut.createFolder({
145146
folderName: 'test-folder',
146147
parentFolderUuid: 'parent-uuid',
147148
});
148-
const endTime = Date.now();
149+
150+
await vi.advanceTimersByTimeAsync(500);
151+
152+
const result = await createPromise;
149153

150154
expect(result.uuid).to.equal('test-uuid');
151155
expect(result.name).to.equal('test-folder');
152-
expect(endTime - startTime).toBeGreaterThanOrEqual(500);
153156
expect(driveFolderService.createFolder).toHaveBeenCalledWith({
154157
plainName: 'test-folder',
155158
parentFolderUuid: 'parent-uuid',
156159
});
160+
161+
vi.useRealTimers();
157162
});
158163
});
159164
});

0 commit comments

Comments
 (0)