From 0ef1a795a091b7d22c6f56404709c8efadd04ee1 Mon Sep 17 00:00:00 2001 From: jzunigax2 <125698953+jzunigax2@users.noreply.github.com> Date: Mon, 12 Jan 2026 14:06:31 -0600 Subject: [PATCH 1/2] refactor(backup): remove unnecessary activation check for backups --- src/modules/backups/backup.usecase.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/modules/backups/backup.usecase.ts b/src/modules/backups/backup.usecase.ts index c1f6d6fc8..60d977db6 100644 --- a/src/modules/backups/backup.usecase.ts +++ b/src/modules/backups/backup.usecase.ts @@ -248,10 +248,6 @@ export class BackupUseCase { throw new BadRequestException('You need to send either hostname or key'); } - if (!user.hasBackupsEnabled()) { - await this.activate(user); - } - await this.verifyDeviceDoesNotExist(user, { key: createDeviceDto.key, platform: createDeviceDto.platform, From ea4cffdb9ee6fd7bfec2b156e1aabb61899326a5 Mon Sep 17 00:00:00 2001 From: jzunigax2 <125698953+jzunigax2@users.noreply.github.com> Date: Mon, 12 Jan 2026 14:31:27 -0600 Subject: [PATCH 2/2] test(backup): update tests to reflect changes in createDeviceAsFolder method --- src/modules/backups/backup.usecase.spec.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/modules/backups/backup.usecase.spec.ts b/src/modules/backups/backup.usecase.spec.ts index 919fe48de..a1d9b9320 100644 --- a/src/modules/backups/backup.usecase.spec.ts +++ b/src/modules/backups/backup.usecase.spec.ts @@ -511,9 +511,6 @@ describe('BackupUseCase', () => { ...createDeviceDto, userId: userWithoutBackups.id, }); - jest - .spyOn(backupUseCase, 'activate') - .mockResolvedValue({ backupsBucket: 'new-bucket' }); jest .spyOn(backupRepository, 'findConflictingUserDevice') .mockResolvedValue(null); @@ -529,7 +526,10 @@ describe('BackupUseCase', () => { createDeviceDto, ); - expect(backupUseCase.activate).toHaveBeenCalledWith(userWithoutBackups); + expect(backupUseCase.createDeviceAsFolder).toHaveBeenCalledWith( + userWithoutBackups, + createDeviceDto.name, + ); expect(result).toEqual({ ...mockDevice, folder: mockFolder }); });