From 7ec9f514948f6a821fbd3d8fe7eeee0d2ea806ee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 17:27:07 +0100 Subject: [PATCH 01/23] Add sonaclour --- .github/workflows/sonar-analysis.yml | 38 ++++++++++++++++++++++++++++ .gitignore | 1 + sonar-project.properties | 2 ++ 3 files changed, 41 insertions(+) create mode 100644 .github/workflows/sonar-analysis.yml create mode 100644 sonar-project.properties diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml new file mode 100644 index 00000000..e58bf241 --- /dev/null +++ b/.github/workflows/sonar-analysis.yml @@ -0,0 +1,38 @@ +name: SonarCloud code analysis + +on: + pull_request: + types: [opened, synchronize, reopened] + +jobs: + build: + runs-on: windows-latest + + env: + BUILD_WRAPPER_OUT_DIR: build_wrapper_out_dir + + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Setup Node.js + uses: actions/setup-node@v3 + with: + node-version: 18 + + - name: Install Build Wrapper + uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 + + - name: Run Build Wrapper + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npm run build + + - name: SonarQube Scan + uses: SonarSource/sonarqube-scan-action@v5 + env: + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} + with: + args: > + --define sonar.cfamily.compile-commands="${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json" + + diff --git a/.gitignore b/.gitignore index bc299f21..f866b1f2 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,7 @@ /.env /.vscode /addon.node +/bin /build /dist /examples/tmp diff --git a/sonar-project.properties b/sonar-project.properties new file mode 100644 index 00000000..5add1165 --- /dev/null +++ b/sonar-project.properties @@ -0,0 +1,2 @@ +sonar.projectKey=internxt_node-win +sonar.organization=internxt From f4e74d1f4d6f58570354db4a8a678b100cb1024e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 17:38:47 +0100 Subject: [PATCH 02/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index e58bf241..76b30dee 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -25,7 +25,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npm run build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build - name: SonarQube Scan uses: SonarSource/sonarqube-scan-action@v5 From d63b27ed411a1914c1c550a8ba81363f28f9ea8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 17:45:47 +0100 Subject: [PATCH 03/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 76b30dee..495e5c39 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -21,6 +21,9 @@ jobs: with: node-version: 18 + - name: Install node-gyp + run: npm install -g node-gyp + - name: Install Build Wrapper uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 From bf3a9ff98173b1f063097bd348df51b890a859a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 17:54:25 +0100 Subject: [PATCH 04/23] Split in build:addon --- .github/workflows/sonar-analysis.yml | 2 +- package.json | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 495e5c39..e9d9fdda 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -28,7 +28,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npm run build:addon - name: SonarQube Scan uses: SonarSource/sonarqube-scan-action@v5 diff --git a/package.json b/package.json index 7ef35f1e..8e2ee658 100644 --- a/package.json +++ b/package.json @@ -12,9 +12,10 @@ "========== Build ==========": "", "clean": "node-gyp clean", "build:gyp": "node-gyp configure build", - "build:ts": "tsc -p tsconfig.build.json && tsc-alias -p tsconfig.build.json", "config:gyp": "python gyp.config.py", - "build": "python gyp.config.py && node-gyp clean && node-gyp configure build && yarn build:ts", + "build:addon": "python gyp.config.py && node-gyp clean && node-gyp configure build", + "build:ts": "tsc -p tsconfig.build.json && tsc-alias -p tsconfig.build.json", + "build": "npm run build:addon && npm run build:ts", "========== Linter ==========": "", "format": "prettier . --write", "========== Examples ==========": "", From df6aa51e46ba350b25d26312160d0187c2eb2b04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 17:56:41 +0100 Subject: [PATCH 05/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index e9d9fdda..495e5c39 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -28,7 +28,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npm run build:addon + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build - name: SonarQube Scan uses: SonarSource/sonarqube-scan-action@v5 From 0f89037ee2adf89f5a082920b929f25202912509 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:03:25 +0100 Subject: [PATCH 06/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 495e5c39..ee44ba35 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -36,6 +36,6 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} with: args: > - --define sonar.cfamily.compile-commands="${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json" + --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" From 4b4c55152265628a7a31d1d4c6d6315520303ad0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:10:19 +0100 Subject: [PATCH 07/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index ee44ba35..305c019f 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -30,12 +30,14 @@ jobs: - name: Run Build Wrapper run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build + - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} + - name: SonarQube Scan uses: SonarSource/sonarqube-scan-action@v5 env: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} with: args: > - --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" + --define sonar.cfamily.compile-commands="${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json" From 5fb01f98ba1aab9b2cc58125f922ff7e86a79623 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:16:29 +0100 Subject: [PATCH 08/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 305c019f..c185f045 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -31,6 +31,9 @@ jobs: run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} + - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json + - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/build-wrapper.log + - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/build-wrapper-dump.json - name: SonarQube Scan uses: SonarSource/sonarqube-scan-action@v5 From c5d9b5827f3e51735397f6d875e2c1de87b8cc15 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:22:08 +0100 Subject: [PATCH 09/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index c185f045..f9eae811 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -28,7 +28,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} cmd /C "python gyp.config.py && node-gyp clean && node-gyp configure build -- -p:nodeReuse=False" - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From 77929279b433b1461bf1afff9b1504fb940efd7f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:25:36 +0100 Subject: [PATCH 10/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index f9eae811..081cd659 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -9,7 +9,7 @@ jobs: runs-on: windows-latest env: - BUILD_WRAPPER_OUT_DIR: build_wrapper_out_dir + BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory steps: - uses: actions/checkout@v4 @@ -28,7 +28,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} cmd /C "python gyp.config.py && node-gyp clean && node-gyp configure build -- -p:nodeReuse=False" + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From 51c86ae52ed8b46c21b3b21ee0acd8238c2d87bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:29:07 +0100 Subject: [PATCH 11/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 081cd659..8f445c83 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -28,7 +28,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From db579c47714e8f79685514bc64dcff340eaa6792 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:30:58 +0100 Subject: [PATCH 12/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 8f445c83..c7d76245 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -27,6 +27,8 @@ jobs: - name: Install Build Wrapper uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 + - run: ls . + - name: Run Build Wrapper run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure From ad227d9e1cfa2814e9160d15aa66ce8d5f8c00dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:40:03 +0100 Subject: [PATCH 13/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index c7d76245..27b09aa7 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -29,8 +29,10 @@ jobs: - run: ls . + - run: where node-gyp.cmd + - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From a87d3274775e9d90616b758104745006fc09bdad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:42:02 +0100 Subject: [PATCH 14/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 27b09aa7..cb73d300 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -27,12 +27,8 @@ jobs: - name: Install Build Wrapper uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - - run: ls . - - - run: where node-gyp.cmd - - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From c55579fd65884dec09415ee6b0981a7675c6f666 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:45:47 +0100 Subject: [PATCH 15/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index cb73d300..ddaa261d 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -21,14 +21,14 @@ jobs: with: node-version: 18 - - name: Install node-gyp - run: npm install -g node-gyp + - name: Install deps + run: npm install --ignore-scripts - name: Install Build Wrapper uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npm run build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From bf8aa0cada4ba32e57cf43b1ac82fc0dfad0a980 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:48:05 +0100 Subject: [PATCH 16/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index ddaa261d..58f2518a 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -12,7 +12,8 @@ jobs: BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory steps: - - uses: actions/checkout@v4 + - name: Checkout code + uses: actions/checkout@v4 with: fetch-depth: 0 @@ -20,10 +21,13 @@ jobs: uses: actions/setup-node@v3 with: node-version: 18 + registry-url: "https://npm.pkg.github.com" - name: Install deps run: npm install --ignore-scripts + - run: npx node-gyp configure build + - name: Install Build Wrapper uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 From 0c5874ddfc72094628d75b8a4a83994b4959b7f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:54:42 +0100 Subject: [PATCH 17/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 58f2518a..337ddcff 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -23,8 +23,8 @@ jobs: node-version: 18 registry-url: "https://npm.pkg.github.com" - - name: Install deps - run: npm install --ignore-scripts + - name: Install node-gyp + run: npm install -g node-gyp - run: npx node-gyp configure build @@ -32,7 +32,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npm run build + run: build-wrapper-win-x86-642.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From 56d92e2615da7eb0512407632bb7c08a3b14f719 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 18:58:18 +0100 Subject: [PATCH 18/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 337ddcff..a85966eb 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -32,7 +32,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-642.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From 9910cf49dd16f0423ee350c03b93b997f9c3a924 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 19:06:08 +0100 Subject: [PATCH 19/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index a85966eb..df10b05e 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -32,7 +32,8 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build + run: | + build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From 508a2f49bf61e9a1624d9c221a8e31cd196b97f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 19:07:09 +0100 Subject: [PATCH 20/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index df10b05e..7eacb9e4 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -26,8 +26,6 @@ jobs: - name: Install node-gyp run: npm install -g node-gyp - - run: npx node-gyp configure build - - name: Install Build Wrapper uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 From 0e2fc29eca0594f5fc92ba807dfa4261fd469f54 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 19:10:32 +0100 Subject: [PATCH 21/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 7eacb9e4..b4653822 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -31,7 +31,7 @@ jobs: - name: Run Build Wrapper run: | - build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} npx node-gyp configure build + build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From a919e25aa4163e0572b710e9632f9659d8d2effa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 19:43:55 +0100 Subject: [PATCH 22/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index b4653822..077b2f4e 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -21,7 +21,6 @@ jobs: uses: actions/setup-node@v3 with: node-version: 18 - registry-url: "https://npm.pkg.github.com" - name: Install node-gyp run: npm install -g node-gyp @@ -30,8 +29,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: | - build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py && node-gyp clean && node-gyp configure build + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json From bf176ee805a786f5cb6898c4b753bb832357aef4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Jim=C3=A9nez=20Rivera?= Date: Mon, 17 Mar 2025 19:50:11 +0100 Subject: [PATCH 23/23] Update sonar-analysis.yml --- .github/workflows/sonar-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar-analysis.yml b/.github/workflows/sonar-analysis.yml index 077b2f4e..c54798f0 100644 --- a/.github/workflows/sonar-analysis.yml +++ b/.github/workflows/sonar-analysis.yml @@ -29,7 +29,7 @@ jobs: uses: SonarSource/sonarqube-scan-action/install-build-wrapper@v5 - name: Run Build Wrapper - run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} python gyp.config.py + run: build-wrapper-win-x86-64.exe --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} node-gyp configure build - run: ls ${{ env.BUILD_WRAPPER_OUT_DIR }} - run: cat ${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json