Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX bug: if lite terminal is left open for a while, it hangs #1481

Open
isc-kiyer opened this issue Feb 12, 2025 · 7 comments
Open

UX bug: if lite terminal is left open for a while, it hangs #1481

isc-kiyer opened this issue Feb 12, 2025 · 7 comments

Comments

@isc-kiyer
Copy link
Contributor

Would be nice to either cut the connection or give the user a warning somehow instead of just hanging.

Versions:

Extension: v2.12.10

IRIS: IRIS for UNIX (Apple macOS for Apple Silicon) 2024.1 (Build 267_2_23734U) Thu Sep 26 2024 20:10:52 EDT

VS Code:
Version: 1.97.0 (Universal)
Commit: 33fc5a94a3f99ebe7087e8fe79fbe1d37a251016
Date: 2025-02-04T22:41:26.688Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 24.3.0

@isc-bsaviano
Copy link
Contributor

I will try to reproduce this. How long does it need to hang for to see this behavior?

@isc-kiyer
Copy link
Contributor Author

I'm not entirely sure. I will try to reproduce it and let you know. Its a fair amount of time though. At least 15 min

@isc-bsaviano
Copy link
Contributor

I just kept a Lite Terminal open for 64 minutes without even entering anything into it. I then typed a command. The syntax coloring and execution worked.

@gjsjohnmurray
Copy link
Contributor

Do you both have the same "Session timeout" value for your /api/atelier web application?

@isc-bsaviano
Copy link
Contributor

My timeout was the default 3600 seconds. I lowered that to 60, closed all my sessions, and then tried to reproduce this issue. Still couldn't see it.

@isc-kiyer
Copy link
Contributor Author

@isc-bsaviano I tried reproducing it as well and realized this was only an issue when I had to restart my web gateway so makes sense that it isn't otherwise reproducible (I used a web gateway container so often restart it when my IP address changes)

@isc-bsaviano
Copy link
Contributor

Thanks for checking Keshav. I would expect the web server to close the socket in that case but if it's not then I doubt VS Code can do anything about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants