refactor: rename InstallTimeConfig to EnvironmentConfig

Author: isc-shuliu

src/cls/IPM/General/InstallTimeConfig.cls renamed to src/cls/IPM/General/EnvironmentConfig.cls

@@ -1,4 +1,4 @@
-Class %IPM.General.InstallTimeConfig Extends %IPM.General.Singleton
+Class %IPM.General.EnvironmentConfig Extends %IPM.General.Singleton
 {
 
 Property Config As %Library.DynamicObject [ InitialExpression = {{}}, Private ];

src/cls/IPM/Lifecycle/Base.cls

@@ -1793,8 +1793,8 @@ Query Packaging(pPackaging As %String = "") As %SQLQuery [ Final, SqlProc ]
 
 ClassMethod LoadInstallTimeConfig(paths As %String)
 {
-	#dim config As %IPM.General.InstallTimeConfig
-	Set config = ##class(%IPM.General.InstallTimeConfig).%Get()
+	#dim config As %IPM.General.EnvironmentConfig
+	Set config = ##class(%IPM.General.EnvironmentConfig).%Get()
 	Do config.Clear()
 	Set paths = $ListFromString(paths, ";")
 	Set ptr = 0

src/cls/IPM/Main.cls

@@ -61,7 +61,7 @@ Currently, there may only be one of these per namespace.
 <example description="Compiles the module named &quot;MyModuleName&quot;">module-action MyModuleName compile</example>
 <example description="Performs multiple actions on the module named &quot;MyModuleName&quot;; &quot;clean&quot; deletes all of its dependenices, and &quot;install&quot; will then re-download them, package the module, and register it in the current namespace's module cache.">MyModuleName clean register</example>
 <example description="Compiles the module named MyUIModule with verbose output and pParams(&quot;UIFW&quot;,&quot;force&quot;) (passed to all lifecycle phases) set to 42.">MyUIModule compile -v -DUIFW.force=42</example>
-<example description="Verify the module MyModule with the env file /path/to/env.json. The module is responsible for accessing the data using %IPM.General.InstallTimeConfig:GetArg()">MyModule verify -env /path/to/env.json</example>
+<example description="Verify the module MyModule with the env file /path/to/env.json. The module is responsible for accessing the data using %IPM.General.EnvironmentConfig:GetArg()">MyModule verify -env /path/to/env.json</example>
 
 <!-- Parameters -->
 <parameter name="module" required="true" description="Name of module on which to perform lifecycle actions" />
@@ -789,7 +789,7 @@ ClassMethod ShellInternal(pCommand As %String, Output pException As %Exception.A
 {
 	New $$$DeprecationWarned
 	// Keep a reference of the singleton, so subsequent .%Get() calls return the same instance
-	Set configReference = ##class(%IPM.General.InstallTimeConfig).%Get()
+	Set configReference = ##class(%IPM.General.EnvironmentConfig).%Get()
 
 	Set pException = $$$NULLOREF
 	Set tOneCommand = 0

src/cls/IPM/Utils/LegacyCompat.cls

@@ -32,10 +32,9 @@ ClassMethod UpdateSuperclassAndCompile(ByRef pItems, ByRef qSpec = "") As %Statu
         }
     }
 
-    // If the install-time configuration (aka env.json) is set, compile in the current process where singleton %IPM.General.InstallTimeConfig is available 
+    // If the install-time configuration (aka env.json) is set, compile in the current process where singleton %IPM.General.EnvironmentConfig is available 
     // Methods with [CodeMode = objectgenerator] can then use this to access configuration set in env.json
-    Set itconfig = ##class(%IPM.General.InstallTimeConfig).%Get()
-    If 'itconfig.IsEmpty() {
+    If '##class(%IPM.General.EnvironmentConfig).%Get().IsEmpty() {
         Set qSpec = qSpec _ "/multicompile=0"
     }
 

src/cls/IPM/Utils/Module.cls

@@ -221,7 +221,7 @@ ClassMethod LoadQualifiedReference(pReference As %IPM.Storage.QualifiedModuleInf
 ClassMethod LoadModuleReference(pServerName As %String, pModuleName As %String, pVersion As %String, pDeployed As %Boolean, pPlatformVersion As %String, ByRef pParams, ByRef pDependencyGraph) As %Status
 {
 	// Keep a reference of the singleton in this process (which can be a new process!), so subsequent .%Get() calls return the same instance
-	Set configReference = ##class(%IPM.General.InstallTimeConfig).%Get()
+	Set configReference = ##class(%IPM.General.EnvironmentConfig).%Get()
 
 	// Suspend the error count to avoid spurious messages about errors being detected in load/compile.
 	$$$SuspendErrorCount

tests/integration_tests/Test/PM/Integration/InstallTimeConfig.cls

@@ -1,4 +1,4 @@
-Class Test.PM.Integration.InstallTimeConfig Extends Test.PM.Integration.Base
+Class Test.PM.Integration.EnvironmentConfig Extends Test.PM.Integration.Base
 {
 
 Parameter TargetPath = "install-time-config";

tests/integration_tests/Test/PM/Integration/_data/install-time-config/dep/src/InstallTimeConfigDependency/Main.cls

@@ -7,8 +7,8 @@ Parameter PackageName = "install-time-config-dependency";
 
 ClassMethod RunOnLoad() [ CodeMode = objectgenerator ]
 {
-    #dim config As %IPM.General.InstallTimeConfig
-    Set config = ##class(%IPM.General.InstallTimeConfig).%Get()
+    #dim config As %IPM.General.EnvironmentConfig
+    Set config = ##class(%IPM.General.EnvironmentConfig).%Get()
     Set magicValue = config.GetArg(..#PackageName, "nested", "magic")
     If magicValue '= ..#MagicValue {
         If magicValue = "" {

tests/integration_tests/Test/PM/Integration/_data/install-time-config/package/src/InstallTimeConfig/Main.cls

@@ -1,4 +1,4 @@
-Class InstallTimeConfig.Main Extends InstallTimeConfigDependency.Main
+Class EnvironmentConfig.Main Extends InstallTimeConfigDependency.Main
 {
 
 Parameter MagicValue = 42;
@@ -9,8 +9,8 @@ Parameter PackageName = "install-time-config";
 
 ClassMethod RunOnLoad() [ CodeMode = objectgenerator ]
 {
-    #dim config As %IPM.General.InstallTimeConfig
-    Set config = ##class(%IPM.General.InstallTimeConfig).%Get()
+    #dim config As %IPM.General.EnvironmentConfig
+    Set config = ##class(%IPM.General.EnvironmentConfig).%Get()
     Set magicValue = config.GetArg(..#PackageName, "nested", "magic")
     If magicValue '= ..#MagicValue {
         If magicValue = "" {

tests/unit_tests/Test/PM/Unit/MergeJSON.cls

@@ -77,7 +77,7 @@ Method TestMergeDynamicObjects()
     Set allTestCases = [].%FromJSON(stream)
     Set iter = allTestCases.%GetIterator()
     While iter.%GetNext(.key, .case) {
-        Do ##class(%IPM.General.InstallTimeConfig).MergeDynamicObjects(case.dest, case.src)
+        Do ##class(%IPM.General.EnvironmentConfig).MergeDynamicObjects(case.dest, case.src)
         If '$$$AssertTrue(..Equal(case.dest, case.expected)) {
             Set message = $$$FormatText("Failed test case: %1, output = %2", case.%ToJSON(), case.dest.%ToJSON())
             Do $$$LogMessage(message)