From c07bd63d33accadfcfb63d2fcab14309c4f3a06e Mon Sep 17 00:00:00 2001 From: Brett Saviano Date: Fri, 19 Apr 2024 09:13:16 -0400 Subject: [PATCH] Fixes #325 --- CHANGELOG.md | 1 + server/src/providers/completion.ts | 15 +++++++++------ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e378774..4811016 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ - Fix issue [#322](https://github.com/intersystems/language-server/issues/322): Add setting to disable undefined variable warning diagnostics - Fix issue [#323](https://github.com/intersystems/language-server/issues/323): Go to definition on `##super()` will open the superclass's implementation - Fix issue [#324](https://github.com/intersystems/language-server/issues/324): Add intellisense for variables set to JSON literal constructors +- Fix issue [#325](https://github.com/intersystems/language-server/issues/325): Don't sort inherited `%%OID` members at the top of completion lists - Parser changes: - DP-430347: Track variables in routine procedure blocks - DP-430473: Fix variable tracking with embedded SQL in routine procedure blocks diff --git a/server/src/providers/completion.ts b/server/src/providers/completion.ts index e5ae06a..1cfc0a1 100644 --- a/server/src/providers/completion.ts +++ b/server/src/providers/completion.ts @@ -33,6 +33,9 @@ export let schemaCaches: Map = new Map(); */ var macroCompletionCache: MacroContext; +/** Prefix for `sortText` used to bubble base class members to the top of the list. */ +const sortPrefix = "!!!"; + /** * Mapping between an XML prefix and namespace. */ @@ -1112,7 +1115,7 @@ export async function onCompletion(params: CompletionParams): Promise