Skip to content

Conversation

@Samk13
Copy link
Member

@Samk13 Samk13 commented Oct 27, 2025

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

  • I'm aware of the code of conduct.
  • I've created logical separate commits and followed the commit message format.
  • I've targeted the master branch.
  • If this documentation change impacts the current release of InvenioRDM, I will backport it to the production branch following approval or indicate to a maintainer that it should be backported.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

* The download link for the affiliations_ror.yaml file has been removed.
* see:
inveniosoftware/cookiecutter-invenio-rdm#282
data-file: vocabularies/affiliations_ror.yaml
```
The `affiliations_ror.yaml` file can be downloaded from [here](https://github.com/inveniosoftware/cookiecutter-invenio-rdm/raw/master/%7B%7Bcookiecutter.project_shortname%7D%7D/app_data/vocabularies/affiliations_ror.yaml).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update it to https://github.com/inveniosoftware/cookiecutter-invenio-rdm/blob/v12.0/%7B%7Bcookiecutter.project_shortname%7D%7D/app_data/vocabularies/affiliations_ror.yaml

There's a bigger question of how to talk about features from old versions.....but using the v12 link is the fastest way to fix this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link was valid in v12, but it’s outdated for the current v13 and the upcoming master (v14), as the file is no longer part of the setup, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could still use the v12 file in v13 or v14....but it's very out of date and not recommended. Basically everything in the documentation from line 44 onward isn't recommended anymore. But it's possible if some folks want a customized affiliation list they might want to use it. The whole section should probably be re-written with a very small in-line yaml example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let’s get one more opinion on this?
The link’s broken, and that file is no longer in use, so I’m not sure it’s worth keeping this piece of info unless there’s a strong reason to retain the reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants