Allow custom configuration variables for web and worker pods

[egabancho]

It'll be interesting to allow to have different configurations depending on the kind of deployment.
I'm thinking, in particular, setting SENTRY_TRANSPORT = 'raven.transport.http.HTTPTransport' on the celery workers https://invenio-logging.readthedocs.io/en/latest/configuration.html.

I'm thinking something as simple as:

worker:
  extraEnvVars:
    - name: INVENIO_SENTRY_TRANSPORT
      value: 'raven.transport.http.HTTPTransport' 

And then render them as environmental variables directly on the container.

[lindhe]

I think that would make a lot of sense. But I also think that the current structure of the values file is suboptimal in general. Maybe we could consider changing the structure while working with this change? It feels so arbitrary and organic to have some stuff inside of invenio.* and some stuff outside. As if web and worker weren't part of invenio. 😕

[egabancho]

I totally agree. It is somewhat odd 😅
What do you have in mind?

[lindhe]

Not much in mind, unfortunately. Hard to know where to start with this problem. There's plenty of components, so I guess having one field per component might make sense. But then there's some things that are shared between components, e.g., between web and worker. Maybe that should go inside of global?

Do you have any idea where to start? Probably best to do it piece by piece, rather than a big bang migration…

[egabancho]

How does this relate to #117 and #118?

I like the idea of global, every other chart I've used seems to have it.

[lindhe]

I think global was popularized by Bitnami, which is why many charts use it. It's a pretty good pattern in my opinion, even if I sometimes get confused about exactly what is considered "global" scope.

Probably has more to do with #118 than #117, but yeah it's a big overlap. And you are right to bring that up, we should probably keep the conversation in one of the other Issues instead.