-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to "machines" interface #32
Comments
As the machines interface seems to be up and running - is there any reason not to try to go ahead with this? Looking at the inventree-cups-plugin it should be pretty straight forward and I could give it a try, unless you happen to have something cooking but not released yet already... |
@simonkuehling I would appreciate you taking the lead on this! It would be great to support multiple machines for this, 100% LMK if you hit any problems on the way. |
@SchrodingersGat I have something working now - could you have a quick look at https://github.com/simonkuehling/inventree-brother-plugin/blob/machine-registry-integration/inventree_brother/brother_plugin.py for comments? there could be a bit more actual logic tracking the machine status - but I'm not sure if we get any information in this regard out of the BrotherQL library... One issue is remaining right now: when printing a label, I get two notification popups in the bottom right corner (using PUI) - one with "success" and another says label generation failed: ![]() I cannot find any errors (running in vscode devcontainer with demo dataset at the moment) - do you have an idea? |
@simonkuehling this looks promising - maybe open up a PR, this feels pretty ready. Regarding status: there are some fairly new status-requesting APIs in borther-ql_inventree that could be helpful. I would like to keep the stump you already have for now as there is probably some testing and discussion required for states. |
The error you are seeing is in the frontend code, because machines make use of the async printing, and that currently falsely shows an error to the user in PUI. That still needs to be implemented on the frontend side. Maybe with web sockets or polling and a notification with a progress bar at the bottom. |
@wolflu05 is there an outstanding issue for the PUI bug you referenced? |
Not sure, but I don't think so. I haven't added this implementation. |
Closed with #46 |
Ref: inventree/InvenTree#4824
Once the linked PR is merged, update this plugin to make use of the new machines interface. With this we should be able to:
The text was updated successfully, but these errors were encountered: