signInWithPhoneNumber needs appVerifier: ApplicationVerifier

[efstathiosntonas]

Don't know if this is a types bug but signInWithPhoneNumber takes 3 arguments, auth, phoneNumber and appVerifier.

According to Firebase docs, we "need" to pass a reCAPTCHA verifier so 2 things are happening:

1. We should use auth.signInWithPhoneNumber and just pass 2 params (bye bye modular 😭 )
2. The typings are wrong and either appVerifier should be removed or be optional.

@mikehardy @russellwheatley I believe it's a bug on typings though, let me know if you want me to open an issue:

import { signInWithPhoneNumber} from '@react-native-firebase/auth'

in screenshot below auth is const auth = getAuth()

[efstathiosntonas]

On top of that,

FacebookAuthProvider is not exported anywhere, neither AppleAuthProvider

while on Firebase docs:

import { getAuth, getRedirectResult, FacebookAuthProvider } from "firebase/auth";

for AppleAuthProvider, it does not exist at all and docs state to use OAuthProvider:

import { getAuth, signInWithPopup, OAuthProvider } from "firebase/auth";

[efstathiosntonas]

also this one:

[mikehardy]

Was ripping through as much of this stuff as I could over the weekend, but clearly there's a bit more to do!
I really appreciate all these even though it may take some time to work through them - they do all look like typing errors.

In general - same as the old namespaced APIs - if there is some area where we are not working like firebase-js-sdk such that we function as a drop-in replacement, the assumption is react-native-firebase is doing it wrong and we have work to do here.

So posting up anything you see that we haven't gotten yet is useful and we'll try to correct