Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [auth] Include access token and ID token in auth result #8316

Open
henribru opened this issue Feb 11, 2025 · 0 comments
Open

🚀 [auth] Include access token and ID token in auth result #8316

henribru opened this issue Feb 11, 2025 · 0 comments
Labels
Needs Attention type: enhancement Implements a new Feature

Comments

@henribru
Copy link

henribru commented Feb 11, 2025

The upstream SDKs for iOS, Android and web allow you to get the user, additional user info, the access token and the ID token after doing an OpenID Connect sign-in. For the access token and the ID token:

However, this wrapper only seems to expose the user and the additional user info. The auth result is handled by promiseWithAuthResult on Android and iOS, and you can see that they only return those two:

On the React Native side the result goes on to _setUserCredential: https://github.com/invertase/react-native-firebase/blob/main/packages/auth/lib/index.js#L181

It would be useful to have parity with the upstream by including the tokens as well.

@henribru henribru added Needs Attention type: enhancement Implements a new Feature labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention type: enhancement Implements a new Feature
Projects
None yet
Development

No branches or pull requests

1 participant