Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonyms filter does not work correctly. #197

Open
paulpilone opened this issue May 24, 2022 · 2 comments
Open

Synonyms filter does not work correctly. #197

paulpilone opened this issue May 24, 2022 · 2 comments
Assignees
Labels
backend Related to the Search API component bug Something isn't working

Comments

@paulpilone
Copy link
Collaborator

The SPARQL query to discover synonyms and like words is not correct. Also, we want to make sure that synonyms get the same operator and field as the originating term.

@paulpilone paulpilone self-assigned this May 24, 2022
@paulpilone paulpilone added bug Something isn't working backend Related to the Search API component labels May 26, 2022
@paulpilone
Copy link
Collaborator Author

Using queries from #117 to fix this issue. The plan is load like terms during ontology ingest and save them in the terms index. At search time, we'll query the term index for an exact match and use the like words as part of our Elasticsearch query.

@paulpilone
Copy link
Collaborator Author

This is a big fix:

  • Update the terms mapping to include alternate terms (e.g. synonyms, like words, alternate labels).
  • Update the ingest code to handle indexing terms and their alternate terms.
  • Update the search API to fetch alternate terms for a search keyword if the synonyms option is true.
  • Update the search API to include alternate terms in the search document
  • Ensure that the boolean operator and field are correctly applied to the alternate terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the Search API component bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant