Skip to content

Commit 35a8ca9

Browse files
authored
don't trigger "Replace/Prefix with _" on Wild (#1083)
1 parent 613efd8 commit 35a8ca9

File tree

2 files changed

+28
-3
lines changed

2 files changed

+28
-3
lines changed

src/FsAutoComplete/CodeFixes/RenameUnusedValue.fs

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,18 @@ let fix (getParseResultsForFile: GetParseResultsForFile) =
8181
if mfv.IsMemberThisValue then
8282
return [ mkReplaceFix diagnostic.Range ]
8383
elif mfv.IsValue then
84-
return
85-
[ tryMkValueReplaceFix diagnostic.Range; tryMkPrefixFix diagnostic.Range ]
86-
|> List.choose id
84+
let symbolText =
85+
lines.GetText symbolUse.Range
86+
|> function
87+
| Ok r -> r
88+
| Error _ -> ""
89+
90+
if symbolText <> "_" then
91+
return
92+
[ tryMkValueReplaceFix diagnostic.Range; tryMkPrefixFix diagnostic.Range ]
93+
|> List.choose id
94+
else
95+
return []
8796
else
8897
return []
8998
| _ -> return []

test/FsAutoComplete.Tests.Lsp/CodeFixTests/Tests.fs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,6 +1698,22 @@ let private renameUnusedValue state =
16981698
"""
16991699
(Diagnostics.acceptAll)
17001700
selectPrefix
1701+
1702+
testCaseAsync "prefix doesn't trigger for _" <|
1703+
CodeFix.checkNotApplicable server
1704+
"""
1705+
let $0_ = 6
1706+
"""
1707+
(Diagnostics.acceptAll)
1708+
selectPrefix
1709+
1710+
testCaseAsync "replace doesn't trigger for _" <|
1711+
CodeFix.checkNotApplicable server
1712+
"""
1713+
let $0_ = 6
1714+
"""
1715+
(Diagnostics.acceptAll)
1716+
selectReplace
17011717
])
17021718

17031719
let private replaceWithSuggestionTests state =

0 commit comments

Comments
 (0)