Skip to content

Commit 599ad39

Browse files
authored
fix(ci): iota-rosetta validation (#4496)
* refactor(ci): skip on condition genesis creation for rosetta setup Since there is no cleanup in the setup and we use a self-hosted runner, the genesis persists between runs. * fix(iota-rosetta): disable historical balance checks We don't support account-balances lookups at specific heights (at least in a trivial matter). So the following applies ``` $ ./bin/rosetta-cli check:data --help By default, account balances are looked up at specific heights (instead of only at the current block). If your node does not support this functionality set historical balance disabled to true. This will make reconciliation much less efficient but it will still work. ``` * fixup! refactor(ci): skip on condition genesis creation for rosetta setup * fixup! fixup! refactor(ci): skip on condition genesis creation for rosetta setup
1 parent 857d515 commit 599ad39

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/scripts/rosetta/setup.sh

+4-5
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,11 @@ echo "Install binaries"
77
cargo install --locked --bin iota --path crates/iota
88
cargo install --locked --bin iota-rosetta --path crates/iota-rosetta
99

10-
echo "create dedicated config dir for IOTA genesis"
11-
CONFIG_DIR="~/.iota/rosetta_config"
12-
mkdir -p $CONFIG_DIR
13-
1410
echo "run IOTA genesis"
15-
iota genesis -f --working-dir $CONFIG_DIR
11+
CONFIG_DIR=~/.iota/iota_config
12+
if ! [ -d "$CONFIG_DIR" ]; then
13+
iota genesis
14+
fi
1615

1716
echo "generate rosetta configuration"
1817
iota-rosetta generate-rosetta-cli-config --online-url http://127.0.0.1:9002 --offline-url http://127.0.0.1:9003

crates/iota-rosetta/resources/rosetta_cli.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"log_balance_changes": false,
3535
"log_reconciliations": false,
3636
"ignore_reconciliation_error": false,
37-
"historical_balance_disabled": false,
37+
"historical_balance_disabled": true,
3838
"exempt_accounts": "",
3939
"bootstrap_balances": "",
4040
"interesting_accounts": "",
@@ -55,4 +55,4 @@
5555
}
5656
},
5757
"perf": null
58-
}
58+
}

0 commit comments

Comments
 (0)