Skip to content

Commit 8769b45

Browse files
authored
Fix coding error in ReadMeterEntry() (#318)
- The ReadSingleIndirectMeterEntryTest test case failed because ReadMeterEntry() was calling FindResourceTypeByID() with the table_id instead of meter_entry.meter_id(). Corrected this, and the test case passes. - Reenabled the ReadSingleIndirectMeterEntryTest test case. Signed-off-by: Derek Foster <derek.foster@intel.com>
1 parent e7c1afa commit 8769b45

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

stratum/hal/lib/tdi/tdi_table_manager.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -977,8 +977,8 @@ ::util::Status TdiTableManager::ReadMeterEntry(
977977
ASSIGN_OR_RETURN(uint32 table_id,
978978
tdi_sde_interface_->GetTdiRtId(meter_entry.meter_id()));
979979

980-
ASSIGN_OR_RETURN(auto resource_type,
981-
p4_info_manager_->FindResourceTypeByID(table_id));
980+
ASSIGN_OR_RETURN(auto resource_type, p4_info_manager_->FindResourceTypeByID(
981+
meter_entry.meter_id()));
982982

983983
if (resource_type == "Meter") {
984984
{

stratum/hal/lib/tdi/tdi_table_manager_test.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,7 @@ TEST_F(TdiTableManagerTest, DISABLED_RejectMeterEntryInsertDelete) {
357357
EXPECT_EQ(ERR_INVALID_PARAM, ret.error_code());
358358
}
359359

360-
// See https://github.com/ipdk-io/stratum-dev/issues/315.
361-
TEST_F(TdiTableManagerTest, DISABLED_ReadSingleIndirectMeterEntryTest) {
360+
TEST_F(TdiTableManagerTest, ReadSingleIndirectMeterEntryTest) {
362361
ASSERT_OK(PushTestConfig());
363362
auto session_mock = std::make_shared<SessionMock>();
364363
constexpr int kP4MeterId = 55555;

0 commit comments

Comments
 (0)