debug: remove error assertions

We inserted these while transitioning to the new API but we've never hit one.

Author: Stebalien

chan.go

@@ -6,7 +6,6 @@ import (
 	"sync"
 
 	"github.com/ipfs/go-ipfs-cmdkit"
-	"github.com/ipfs/go-ipfs-cmds/debug"
 )
 
 func NewChanResponsePair(req *Request) (ResponseEmitter, Response) {
@@ -130,12 +129,6 @@ func (re *chanResponseEmitter) Emit(v interface{}) error {
 	re.wl.Lock()
 	defer re.wl.Unlock()
 
-	// Initially this library allowed commands to return errors by sending an
-	// error value along a stream. We removed that in favour of CloseWithError,
-	// so we want to make sure we catch situations where some code still uses the
-	// old error emitting semantics and _panic_ in those situations.
-	debug.AssertNotError(v)
-
 	// unblock Length()
 	select {
 	case <-re.waitLen:

cli/responseemitter.go

@@ -9,7 +9,6 @@ import (
 	"syscall"
 
 	"github.com/ipfs/go-ipfs-cmds"
-	"github.com/ipfs/go-ipfs-cmds/debug"
 )
 
 var _ ResponseEmitter = &responseEmitter{}
@@ -137,12 +136,6 @@ func (re *responseEmitter) Emit(v interface{}) error {
 		isSingle = true
 	}
 
-	// Initially this library allowed commands to return errors by sending an
-	// error value along a stream. We removed that in favour of CloseWithError,
-	// so we want to make sure we catch situations where some code still uses the
-	// old error emitting semantics and _panic_ in those situations.
-	debug.AssertNotError(v)
-
 	// channel emission iteration
 	if ch, ok := v.(chan interface{}); ok {
 		v = (<-chan interface{})(ch)

debug/checkerr.go

@@ -10,7 +10,6 @@ import (
 
 	"github.com/ipfs/go-ipfs-cmdkit"
 	cmds "github.com/ipfs/go-ipfs-cmds"
-	"github.com/ipfs/go-ipfs-cmds/debug"
 )
 
 var (
@@ -88,12 +87,6 @@ type responseEmitter struct {
 }
 
 func (re *responseEmitter) Emit(value interface{}) error {
-	// Initially this library allowed commands to return errors by sending an
-	// error value along a stream. We removed that in favour of CloseWithError,
-	// so we want to make sure we catch situations where some code still uses the
-	// old error emitting semantics and _panic_ in those situations.
-	debug.AssertNotError(value)
-
 	// if we got a channel, instead emit values received on there.
 	if ch, ok := value.(chan interface{}); ok {
 		value = (<-chan interface{})(ch)

http/responseemitter.go

@@ -8,7 +8,6 @@ import (
 	"sync"
 
 	"github.com/ipfs/go-ipfs-cmdkit"
-	"github.com/ipfs/go-ipfs-cmds/debug"
 )
 
 func NewWriterResponseEmitter(w io.WriteCloser, req *Request) (ResponseEmitter, error) {
@@ -154,14 +153,6 @@ func (re *writerResponseEmitter) Emit(v interface{}) error {
 		return EmitChan(re, ch)
 	}
 
-	// Initially this library allowed commands to return errors by sending an
-	// error value along a stream. We removed that in favour of CloseWithError,
-	// so we want to make sure we catch situations where some code still uses the
-	// old error emitting semantics.
-	// Also errors may occur both as pointers and as plain values, so we need to
-	// check both.
-	debug.AssertNotError(v)
-
 	if re.closed {
 		return ErrClosedEmitter
 	}