Skip to content

Commit acd876b

Browse files
authored
chore: update benchmarks (#590)
The bugs stopping WebRTC and WebTransport from being testable in browsers have been fixed and shipped so they can be added to the suite.
1 parent c9c644c commit acd876b

File tree

6 files changed

+12
-15
lines changed

6 files changed

+12
-15
lines changed

benchmarks/add-dir/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"@helia/unixfs": "^3.0.4",
1818
"@ipld/dag-pb": "^4.0.2",
1919
"@libp2p/websockets": "^8.0.9",
20-
"aegir": "^43.0.1",
20+
"aegir": "^44.0.1",
2121
"blockstore-fs": "^1.0.1",
2222
"datastore-level": "^10.0.1",
2323
"execa": "^8.0.1",

benchmarks/gc/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
},
1212
"devDependencies": {
1313
"@ipld/dag-pb": "^4.0.6",
14-
"aegir": "^43.0.1",
14+
"aegir": "^44.0.1",
1515
"blockstore-fs": "^1.1.8",
1616
"datastore-level": "^10.1.5",
1717
"execa": "^8.0.1",

benchmarks/transfer/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
"@helia/unixfs": "^3.0.3",
1818
"@ipld/dag-pb": "^4.0.2",
1919
"@libp2p/websockets": "^8.0.19",
20-
"aegir": "^43.0.1",
20+
"aegir": "^44.0.1",
2121
"blockstore-fs": "^1.0.1",
2222
"datastore-level": "^10.0.1",
2323
"execa": "^8.0.1",

benchmarks/transports/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"@libp2p/websockets": "^8.0.19",
2828
"@libp2p/webtransport": "^4.0.29",
2929
"@multiformats/multiaddr": "^12.2.1",
30-
"aegir": "^43.0.1",
30+
"aegir": "^44.0.1",
3131
"blockstore-fs": "^1.1.10",
3232
"blockstore-idb": "^1.1.8",
3333
"datastore-idb": "^2.1.9",

benchmarks/transports/src/runner/helia/recipient.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ const cid = CID.parse(`${process.env.HELIA_CID}`)
1212
const mas = `${process.env.HELIA_MULTIADDRS}`.split(',').map(str => multiaddr(str))
1313
const signal = AbortSignal.timeout(parseInt(process.env.HELIA_TIMEOUT ?? '60000'))
1414

15-
const helia = await getHelia()
16-
1715
try {
16+
const helia = await getHelia()
17+
1818
await helia.libp2p.dial(mas, {
1919
signal
2020
})

benchmarks/transports/src/tests.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,20 +23,23 @@ interface Impl {
2323
}
2424

2525
const webRTCimpls: Record<string, Impl> = {
26-
/*
27-
https://issues.chromium.org/issues/40072842
2826
chromium: {
2927
type: 'helia',
3028
exec: PLAYWRIGHT,
3129
listen: (relay) => `${relay}/p2p-circuit,/webrtc`
3230
},
33-
*/
3431
firefox: {
3532
type: 'helia',
3633
exec: PLAYWRIGHT,
3734
args: ['--browser', 'firefox'],
3835
listen: (relay) => `${relay}/p2p-circuit,/webrtc`
3936
},
37+
webkit: {
38+
type: 'helia',
39+
exec: PLAYWRIGHT,
40+
args: ['--browser', 'webkit'],
41+
listen: (relay) => `${relay}/p2p-circuit,/webrtc`
42+
},
4043
'node.js': {
4144
type: 'helia',
4245
listen: (relay) => `${relay}/p2p-circuit,/webrtc`
@@ -64,21 +67,15 @@ const webSocketimpls: Record<string, Impl> = {
6467
}
6568

6669
const webTransportImpls: Record<string, Impl> = {
67-
/*
68-
// https://issues.chromium.org/issues/326887753?pli=1
6970
chromium: {
7071
type: 'helia',
7172
exec: PLAYWRIGHT
7273
},
73-
*/
74-
/*
75-
playwright ships with firefox 121 at the time of writing, it needs 125
7674
firefox: {
7775
type: 'helia',
7876
exec: PLAYWRIGHT,
7977
args: ['--browser', 'firefox']
8078
},
81-
*/
8279
kubo: {
8380
type: 'kubo',
8481
listen: () => '/ip4/127.0.0.1/udp/0/quic-v1/webtransport'

0 commit comments

Comments
 (0)