Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MV3 handling of subdomain gateways creates too many rules #1255

Closed
Tracked by #1253 ...
lidel opened this issue Aug 3, 2023 · 1 comment
Closed
Tracked by #1253 ...

MV3 handling of subdomain gateways creates too many rules #1255

lidel opened this issue Aug 3, 2023 · 1 comment
Assignees

Comments

@lidel
Copy link
Member

lidel commented Aug 3, 2023

origin: '^https?\\:\\/\\/bafybeigfejjsuq5im5c3w3t3krsiytszhfdc4v5myltcg4myv2n2w6jumy\\.ipfs\\.dweb\\.link',
destination: 'http://localhost:8080/ipfs/bafybeigfejjsuq5im5c3w3t3krsiytszhfdc4v5myltcg4myv2n2w6jumy'

We should not create one rule per CID when we know this is a subdomain gateway.

Once we confirm URL is a valid subdomain gateway URL, we should be able to add a single catch-all function for both *.ipfs.dweb.link and *.ipns.dweb.link

@lidel lidel added need/triage Needs initial labeling and prioritization mv3-beta-bugs labels Aug 3, 2023
@whizzzkid whizzzkid self-assigned this Aug 4, 2023
@SgtPooki SgtPooki removed the need/triage Needs initial labeling and prioritization label Aug 7, 2023
@whizzzkid
Copy link
Contributor

Closed with #1260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants