From 351b8a7b5078e282e491d5508d3e29bf4b466531 Mon Sep 17 00:00:00 2001 From: Alex Potsides Date: Tue, 13 Aug 2024 10:53:53 +0100 Subject: [PATCH] docs: apply suggestions from code review Co-authored-by: Guillaume Michel --- src/routing/http-routing-v1.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/routing/http-routing-v1.md b/src/routing/http-routing-v1.md index 350c68e3..d8b01d61 100644 --- a/src/routing/http-routing-v1.md +++ b/src/routing/http-routing-v1.md @@ -116,7 +116,7 @@ Each object in the `Providers` list is a record conforming to a schema, usually - `closerThan` is an optional [Peer ID](https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md) represented as a CIDv1 encoded with `libp2p-key` codec. - Returned peer records must be closer to `peer-id` than `closerThan`. - - If omitted the routing implementation should use it's own [Peer ID](https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md). + - If omitted the routing implementation should use its own [Peer ID](https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md). - `count` is an optional number that specifies how many peer records the requester desires. - Minimum 1, maximum 100, default 20. @@ -134,7 +134,7 @@ Each object in the `Providers` list is a record conforming to a schema, usually - When present, `ttl` SHOULD be shorter for responses whose resolution ended in no results (e.g. 15 seconds), and longer for responses that have results (e.g. 5 minutes). - Implementations SHOULD include `max-ttl`, set to the maximum cache window of the underlying routing system. - For example, if Amino DHT results are returned, `stale-while-revalidate` SHOULD be set to `172800` (48h, which at the time of writing this specification, is the provider record expiration window). + For example, if Amino DHT results are returned, `stale-while-revalidate` SHOULD be set to `79200` (22h, which at the time of writing this specification, is the [Provider Record Republish Interval](https://github.com/libp2p/specs/tree/master/kad-dht#content-provider-advertisement-and-discovery)). - `Vary: Accept`: allows intermediate caches to play nicely with the different possible content types. #### Response Body