Partial revert of #19247. This test has been flaky, particularly on Windows. More context here: #20306 (comment). > That gisel_abort test is weird - we should kill it and reimplement it properly (it looks like it's checking for an abort code in lowering all the way from stream level, which is not a unit test - that's an integration test, and an odd one - it should be using the IR at the lowest level immediately prior to the error, then checking for a properly handled errors, not aborts) Sample logs: https://github.com/iree-org/iree/actions/runs/13955504318/job/39065465061?pr=20306#step:10:584 ``` 230/1561 Test #82: iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir.test .....................................................***Failed 7.94 sec -- Testing: 1 tests, 1 workers -- FAIL: IREE :: plugins/target/ROCM/test/gisel_abort.mlir (1 of 1) ******************** TEST 'IREE :: plugins/target/ROCM/test/gisel_abort.mlir' FAILED ******************** Exit Code: 1 Command Output (stderr): -- RUN: at line 1: not not iree-opt --iree-hip-llvm-global-isel --iree-hal-transformation-pipeline --iree-gpu-test-target=gfx90a C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir 2>&1 | FileCheck C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir + not not iree-opt --iree-hip-llvm-global-isel --iree-hal-transformation-pipeline --iree-gpu-test-target=gfx90a C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir + FileCheck C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir:29:12: error: CHECK: expected string not found in input // CHECK: llvm::reportGISelFailure ^ <stdin>:1:94: note: scanning from here LLVM ERROR: unable to map instruction: G_INTRINSIC_W_SIDE_EFFECTS intrinsic(@llvm.x86.wrpkru), %31:vgpr(s32) (in function: add_dispatch) ^ <stdin>:2:2: note: possible intended match here Please report issues to https://github.com/iree-org/iree/issues and include the crash backtrace. ^ Input file: <stdin> Check file: C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir -dump-input=help explains the following input dump. Input was: <<<<<< 1: LLVM ERROR: unable to map instruction: G_INTRINSIC_W_SIDE_EFFECTS intrinsic(@llvm.x86.wrpkru), %31:vgpr(s32) (in function: add_dispatch) check:29'0 X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found 2: Please report issues to https://github.com/iree-org/iree/issues and include the crash backtrace. check:29'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ check:29'1 ? possible intended match 3: Stack dump: check:29'0 ~~~~~~~~~~~~ 4: 0. Program arguments: iree-opt --iree-hip-llvm-global-isel --iree-hal-transformation-pipeline --iree-gpu-test-target=gfx90a C:/home/runner/_work/iree/iree/compiler/plugins/target/ROCM/test/gisel_abort.mlir check:29'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5: 1. Running pass 'CallGraph Pass Manager' on module 'add_dispatch_executable'. check:29'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 6: 2. Running pass 'RegBankSelect' on function '@add_dispatch' check:29'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 7: Exception Code: 0x80000003 check:29'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ . . . >>>>>> -- ******************** ******************** Failed Tests (1): IREE :: plugins/target/ROCM/test/gisel_abort.mlir ``` Signed-off-by: Scott Todd <scott.todd0@gmail.com>
-Original file line number
+Diff line change
     lit
   SRCS
     "external_function_validation.mlir"
 -    "gisel_abort.mlir"
     "smoketest.mlir"
     "target_device_features.mlir"
   TOOLS