Skip to content

avoid exceeding recursion depth limit when handling large responses #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

avoid exceeding recursion depth limit when handling large responses #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions aioimaplib/aioimaplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,35 +356,36 @@ def connection_lost(self, exc: Optional[Exception]) -> None:
self.conn_lost_cb(exc)

def _handle_responses(self, data: bytes, line_handler: Callable[[bytes, Command], Optional[Command]], current_cmd: Command = None) -> None:
if not data:
if self.pending_sync_command is not None:
self.pending_sync_command.flush()
if current_cmd is not None and current_cmd.wait_data():
raise IncompleteRead(current_cmd)
return
while data:
if current_cmd is not None and current_cmd.wait_literal_data():
data = current_cmd.append_literal_data(data)
if current_cmd.wait_literal_data():
raise IncompleteRead(current_cmd)

line, separator, tail = data.partition(CRLF)
if not separator:
raise IncompleteRead(current_cmd, data)

cmd = line_handler(line, current_cmd)

begin_literal = literal_data_re.match(line)
if begin_literal:
size = int(begin_literal.group('size'))
if cmd is None:
cmd = Command('NIL', 'unused')
cmd.begin_literal_data(size)
current_cmd = cmd
elif cmd is not None and cmd.wait_data():
current_cmd = cmd
else:
current_cmd = None

data = tail

if current_cmd is not None and current_cmd.wait_literal_data():
data = current_cmd.append_literal_data(data)
if current_cmd.wait_literal_data():
raise IncompleteRead(current_cmd)

line, separator, tail = data.partition(CRLF)
if not separator:
raise IncompleteRead(current_cmd, data)

cmd = line_handler(line, current_cmd)

begin_literal = literal_data_re.match(line)
if begin_literal:
size = int(begin_literal.group('size'))
if cmd is None:
cmd = Command('NIL', 'unused')
cmd.begin_literal_data(size)
self._handle_responses(tail, line_handler, current_cmd=cmd)
elif cmd is not None and cmd.wait_data():
self._handle_responses(tail, line_handler, current_cmd=cmd)
else:
self._handle_responses(tail, line_handler)
if self.pending_sync_command is not None:
self.pending_sync_command.flush()
if current_cmd is not None and current_cmd.wait_data():
raise IncompleteRead(current_cmd)

def _handle_line(self, line: bytes, current_cmd: Command) -> Optional[Command]:
if not line:
Expand Down